Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752487AbdDCLhY (ORCPT ); Mon, 3 Apr 2017 07:37:24 -0400 Received: from mail.free-electrons.com ([62.4.15.54]:58868 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751342AbdDCLhX (ORCPT ); Mon, 3 Apr 2017 07:37:23 -0400 Date: Mon, 3 Apr 2017 13:37:21 +0200 From: Maxime Ripard To: Corentin Labbe Cc: robh+dt@kernel.org, mark.rutland@arm.com, wens@csie.org, linux@armlinux.org.uk, catalin.marinas@arm.com, will.deacon@arm.com, peppe.cavallaro@st.com, alexandre.torgue@st.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v3 12/20] ARM: dts: sun8i: Enable dwmac-sun8i on the Orange Pi plus Message-ID: <20170403113721.nijh2uwgepfkrpm4@lukather> References: <20170403091444.29876-1-clabbe.montjoie@gmail.com> <20170403091444.29876-13-clabbe.montjoie@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="4ci5l4fbjve5uyrx" Content-Disposition: inline In-Reply-To: <20170403091444.29876-13-clabbe.montjoie@gmail.com> User-Agent: Mutt/1.6.2-neo (2016-08-21) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2721 Lines: 86 --4ci5l4fbjve5uyrx Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Apr 03, 2017 at 11:14:36AM +0200, Corentin Labbe wrote: > The dwmac-sun8i hardware is present on the Orange PI plus. > It uses an external PHY rtl8211e via RGMII. >=20 > This patch create the needed regulator, emac and phy nodes. >=20 > Signed-off-by: Corentin Labbe > --- > arch/arm/boot/dts/sun8i-h3-orangepi-plus.dts | 36 ++++++++++++++++++++++= ++++++ > 1 file changed, 36 insertions(+) >=20 > diff --git a/arch/arm/boot/dts/sun8i-h3-orangepi-plus.dts b/arch/arm/boot= /dts/sun8i-h3-orangepi-plus.dts > index 8c40ab7..6852006 100644 > --- a/arch/arm/boot/dts/sun8i-h3-orangepi-plus.dts > +++ b/arch/arm/boot/dts/sun8i-h3-orangepi-plus.dts > @@ -58,6 +58,18 @@ > enable-active-high; > gpio =3D <&pio 6 11 GPIO_ACTIVE_HIGH>; > }; > + > + reg_gmac_3v3: gmac-3v3 { > + compatible =3D "regulator-fixed"; > + pinctrl-names =3D "default"; > + pinctrl-0 =3D <&gmac_power_pin_orangepi>; > + regulator-name =3D "gmac-3v3"; > + regulator-min-microvolt =3D <3300000>; > + regulator-max-microvolt =3D <3300000>; > + startup-delay-us =3D <100000>; > + enable-active-high; > + gpio =3D <&pio 3 6 GPIO_ACTIVE_HIGH>; > + }; > }; > =20 > &ehci3 { > @@ -86,8 +98,32 @@ > pins =3D "PG11"; > function =3D "gpio_out"; > }; > + > + gmac_power_pin_orangepi: gmac_power_pin@0 { > + pins =3D "PD6"; > + function =3D "gpio_out"; > + drive-strength =3D <10>; > + }; This is not needed, and will even harm the fixing of a bug that will require to remove all the GPIO nodes. It works fine without it, please remove it. Thanks! Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com --4ci5l4fbjve5uyrx Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIcBAEBCAAGBQJY4jPtAAoJEBx+YmzsjxAgEjYQAKKcmP5Fs5K6+hCN2dntY8PQ mZMN2gIiNoTxOsCSew/1MfHlbcqJTUgV5SHC5kvNi+ePiLfiWeHKo4qqyJRo7BXt MOwuulhsFaFYShSt0CG+LQYcUwA1GhhDoAUomR0mqa/GzbGr5OvgxvUhCoiFNJR4 WmpEkIfeML8wxLsQmsqtzKOvE1gS2o0W1FEk+i3vbxyMoz+oArAb1ziRlHm/5VHC Unp94rthG5W9YBEw2FNcA7+Vwhl9vHNCEC7huqAJN64ATdsvVwKRyAaXs/a1xpt7 9miFEOUClifY8odKcablORxJ+4JR/v8NnqZ+FxFfC5khbBEbtXnh4We12qgvHgbM n7t1CbjsJ2+6aGlJGBYtBj7JB86QgnZixHI88RyJmCxTU2iZimpMc/YmoUIUiJgr srCUG7mWn/pG1Y7t443BjBv2/QuVBaGzd5q5cuFdv3L/iavrQTQDIhC/J/9a//t2 3BcWoRYLiM5BP3OntdRWfWGJin0MpqveVxg22dcKrOumNyBGcW4fZ3A81K7YiUlu Z4WJVYpskJpoT0YNvSpQ73/REyIg58S01tzdEuDV33PNHLjKkBqVtzBWqrw0XmbU FWeei2YLcIYaT67Ni/JB5lC1mhVBJeU1ZbpenyYMRlIvTt6Z6Lhs6IzChJQbO194 S5Sq9AU9oqSJV3gA49gF =V2KQ -----END PGP SIGNATURE----- --4ci5l4fbjve5uyrx--