Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752887AbdDCMZM (ORCPT ); Mon, 3 Apr 2017 08:25:12 -0400 Received: from bombadil.infradead.org ([65.50.211.133]:56334 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752650AbdDCMZJ (ORCPT ); Mon, 3 Apr 2017 08:25:09 -0400 Date: Mon, 3 Apr 2017 14:25:01 +0200 From: Peter Zijlstra To: hpa@zytor.com Cc: linux-tip-commits@vger.kernel.org, tip-bot for Peter Zijlstra , torvalds@linux-foundation.org, linux-kernel@vger.kernel.org, mingo@kernel.org, tglx@linutronix.de, fengguang.wu@intel.com Subject: Re: [tip:x86/asm] debug: Fix __bug_table[] in arch linker scripts Message-ID: <20170403122501.GA3093@worktop> References: <20170330154927.o6qmgfp4bdhrajbm@hirez.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.22.1 (2013-10-16) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 740 Lines: 23 On Mon, Apr 03, 2017 at 02:57:48AM -0700, hpa@zytor.com wrote: > On April 3, 2017 1:27:49 AM PDT, tip-bot for Peter Zijlstra wrote: > >diff --git a/arch/x86/kernel/vmlinux.lds.S > >b/arch/x86/kernel/vmlinux.lds.S > >index c74ae9c..c8a3b61 100644 > >--- a/arch/x86/kernel/vmlinux.lds.S > >+++ b/arch/x86/kernel/vmlinux.lds.S > >@@ -146,6 +146,7 @@ SECTIONS > > _edata = .; > > } :data > > > >+ BUG_TABLE > > > > . = ALIGN(PAGE_SIZE); > > __vvar_page = .; > > Case in point why we want structured linker tables, btw... Yes. Btw, can you explain why x86 builds and works without this patch? Because as far as I understand this (which isn't very far), we should fail linking with an unresolved symbol without this.