Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752914AbdDCMjp (ORCPT ); Mon, 3 Apr 2017 08:39:45 -0400 Received: from mx07-00178001.pphosted.com ([62.209.51.94]:26251 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752245AbdDCMjn (ORCPT ); Mon, 3 Apr 2017 08:39:43 -0400 Subject: Re: [PATCH v3 01/20] net: stmmac: export stmmac_set_mac_addr/stmmac_get_mac_addr To: Corentin Labbe , , , , , , , , , Alexandre TORGUE References: <20170403091444.29876-1-clabbe.montjoie@gmail.com> <20170403091444.29876-2-clabbe.montjoie@gmail.com> CC: , , , From: Giuseppe CAVALLARO Message-ID: <9514c077-1738-ea49-ca18-fbc46bac6144@st.com> Date: Mon, 3 Apr 2017 14:39:03 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.1.0 MIME-Version: 1.0 In-Reply-To: <20170403091444.29876-2-clabbe.montjoie@gmail.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.75.127.51] X-ClientProxiedBy: SFHDAG8NODE3.st.com (10.75.127.24) To SFHDAG4NODE1.st.com (10.75.127.10) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-04-03_09:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1370 Lines: 39 Hello Alex do you can check if this has to be done for ST platforms? I do not remember that it was necessary when build as module so I cannot expect this should be only for dwmac-sun8i. Regards peppe On 4/3/2017 11:14 AM, Corentin Labbe wrote: > Thoses symbol will be needed for the dwmac-sun8i ethernet driver. > For letting it to be build as module, they need to be exported. > > Signed-off-by: Corentin Labbe > --- > drivers/net/ethernet/stmicro/stmmac/dwmac_lib.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac_lib.c b/drivers/net/ethernet/stmicro/stmmac/dwmac_lib.c > index 38f9430..67af0bd 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/dwmac_lib.c > +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac_lib.c > @@ -248,6 +248,7 @@ void stmmac_set_mac_addr(void __iomem *ioaddr, u8 addr[6], > data = (addr[3] << 24) | (addr[2] << 16) | (addr[1] << 8) | addr[0]; > writel(data, ioaddr + low); > } > +EXPORT_SYMBOL_GPL(stmmac_set_mac_addr); > > /* Enable disable MAC RX/TX */ > void stmmac_set_mac(void __iomem *ioaddr, bool enable) > @@ -279,4 +280,4 @@ void stmmac_get_mac_addr(void __iomem *ioaddr, unsigned char *addr, > addr[4] = hi_addr & 0xff; > addr[5] = (hi_addr >> 8) & 0xff; > } > - > +EXPORT_SYMBOL_GPL(stmmac_get_mac_addr);