Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753139AbdDCMtM (ORCPT ); Mon, 3 Apr 2017 08:49:12 -0400 Received: from boksu.net-space.pl ([185.15.1.105]:33836 "EHLO boksu.net-space.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752416AbdDCMtK (ORCPT ); Mon, 3 Apr 2017 08:49:10 -0400 X-Greylist: delayed 329 seconds by postgrey-1.27 at vger.kernel.org; Mon, 03 Apr 2017 08:49:10 EDT Date: Mon, 3 Apr 2017 14:42:57 +0200 From: Daniel Kiper To: Juergen Gross Cc: linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, boris.ostrovsky@oracle.com, ptesarik@suse.com, daniel.kiper@oracle.com, eric.devolder@oracle.com, konrad.wilk@oracle.com, andrew.cooper3@citrix.com Subject: Re: [Xen-devel] [PATCH v2] xen, kdump: handle pv domain in paddr_vmcoreinfo_note() Message-ID: <20170403124257.GA3439@router-fw-old.local.net-space.pl> References: <20170331101438.28582-1-jgross@suse.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170331101438.28582-1-jgross@suse.com> User-Agent: Mutt/1.3.28i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 710 Lines: 18 On Fri, Mar 31, 2017 at 12:14:38PM +0200, Juergen Gross wrote: > For kdump to work correctly it needs the physical address of > vmcoreinfo_note. When running as dom0 this means the virtual address > has to be translated to the related machine address. > > paddr_vmcoreinfo_note() is meant to do the translation via > __pa_symbol() only, but being attributed "weak" it can be replaced > easily in Xen case. > > Signed-off-by: Juergen Gross Have you tested this patch with latest crash tool? Do dom0 and Xen hypervisor analysis work without any issue (at least basic commands like dmesg, bt, ps, etc.)? If yes for both you can add: Reviewed-by: Daniel Kiper Daniel