Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753230AbdDCNZT (ORCPT ); Mon, 3 Apr 2017 09:25:19 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:54888 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752910AbdDCNZR (ORCPT ); Mon, 3 Apr 2017 09:25:17 -0400 Date: Mon, 3 Apr 2017 15:25:02 +0200 From: Greg KH To: Doug Anderson Cc: arve@android.com, riandrews@android.com, Todd Kjos , devel@driverdev.osuosl.org, "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" Subject: Re: [RFC PATCH] binder: Don't require the binder lock when killed in binder_thread_read() Message-ID: <20170403132502.GA32491@kroah.com> References: <20170331175341.19889-1-dianders@chromium.org> <20170331192944.GB9744@kroah.com> <20170401064856.GA14971@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.8.0 (2017-02-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2003 Lines: 44 On Sat, Apr 01, 2017 at 07:34:53PM -0700, Doug Anderson wrote: > Hi, > > On Fri, Mar 31, 2017 at 11:48 PM, Greg KH wrote: > > On Fri, Mar 31, 2017 at 02:00:13PM -0700, Doug Anderson wrote: > >> On Fri, Mar 31, 2017 at 12:29 PM, Greg KH wrote: > >> BTW: I presume that nobody has decided that it would be a wise idea to > >> pick the OOM reaper code back to any stable trees? It seemed a bit > >> too scary to me, so I wrote a dumber (but easier to backport) solution > >> that avoided the deadlocks I was seeing. http://crosreview.com/465189 > >> and the 3 patches above it in case anyone else stumbles on this thread > >> and is curious. > > > > What specific upstream OOM patches are you referring to? I'm always > > glad to review patches for stable kernels, just email > > stable@vger.kernel.org the git commit ids and we can take it from there. > > +stable > > I was wondering about the concept of porting the OOM Reaper back to > older kernels. The OOM reaper was originally introduced in: > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/mm/oom_kill.c?id=aac453635549699c13a84ea1456d5b0e574ef855 > > Basically the problem described in that patch exists in many older > kernels and I've certainly seen crashes related to this in 3.10, but I > believe older kernels see the same problems too. > > Personally I wouldn't know exactly which patches were important to > backport and how far to go. One could arbitrarily try to backport up > to 4.6.7 (since 4.6 was the first kernel to really have the OOM > reaper) and ignore all the reaper fixes that landed since then. This > would probably be doable for kernel 4.4, though if anyone was trying > to support older kernels it might get harder. Well, I would need someone to give me a list of commits, and actually test it to see if it is something that people use/want before I can queue anything up for a stable release... {hint} thanks, greg k-h