From: Steve Twiss <stwiss.opensource@diasemi.com>
To: Lee Jones <lee.jones@linaro.org>
CC: LINUX-KERNEL <linux-kernel@vger.kernel.org>,
        DEVICETREE <devicetree@vger.kernel.org>,
        Dmitry Torokhov <dmitry.torokhov@gmail.com>,
        Eduardo Valentin <edubezval@gmail.com>,
        Guenter Roeck <linux@roeck-us.net>,
        LINUX-INPUT <linux-input@vger.kernel.org>,
        LINUX-PM <linux-pm@vger.kernel.org>,
        LINUX-WATCHDOG <linux-watchdog@vger.kernel.org>,
        Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>,
        "Mark Rutland" <mark.rutland@arm.com>,
        Rob Herring <robh+dt@kernel.org>,
        "Support Opensource" <Support.Opensource@diasemi.com>,
        Wim Van Sebroeck <wim@iguana.be>, Zhang Rui <rui.zhang@intel.com>
Subject: RE: [PATCH V7 4/7] mfd: da9061: MFD core support
Thread-Topic: [PATCH V7 4/7] mfd: da9061: MFD core support
Thread-Index: AQHSp9MeyoJYoFb5tUuneaXCMwHazKGzqCwAgAARsOA=
Date: Mon, 3 Apr 2017 14:20:09 +0000
Message-ID: <6ED8E3B22081A4459DAC7699F3695FB7018CD6B183@SW-EX-MBX02.diasemi.com>
References: <cover.1490712213.git.stwiss.opensource@diasemi.com>
 <8987877cc54940358c5b7a65ca003cedc5586f0d.1490712213.git.stwiss.opensource@diasemi.com>
 <20170403141214.q6ndii6c47pqfqx6@dell>
In-Reply-To: <20170403141214.q6ndii6c47pqfqx6@dell>
Accept-Language: en-GB, en-US
Content-Language: en-US
x-kse-attachmentfiltering-interceptor-info: protection disabled
x-kse-serverinfo: sw-ex-cashub01.diasemi.com, 9
x-kse-antivirus-interceptor-info: scan successful
x-kse-antivirus-info: Clean, bases: 03/04/2017 12:38:00
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id v33EKNYU027359
Content-Length: 423
Lines: 18

On 03 April 2017 15:12, Lee Jones wrote:

> > @@ -475,7 +855,25 @@ static int da9062_i2c_probe(struct i2c_client *i2c,
> >  		return -EINVAL;
> >  	}
> >
> > -	chip->regmap = devm_regmap_init_i2c(i2c, &da9062_regmap_config);
> > +	switch (chip->chip_type) {
> > +	case(COMPAT_TYPE_DA9061):
> 
> Brackets around the case value?
> 
> That's a new one on me.

Hm. Do you want me to resend it without braces?

Regards,
Stephen