Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753504AbdDCOYi (ORCPT ); Mon, 3 Apr 2017 10:24:38 -0400 Received: from hqemgate16.nvidia.com ([216.228.121.65]:10260 "EHLO hqemgate16.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752490AbdDCOYg (ORCPT ); Mon, 3 Apr 2017 10:24:36 -0400 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Mon, 03 Apr 2017 07:24:35 -0700 Subject: Re: [PATCH 2/3] dt-bindings: Add bindings for nvidia,tegra186-ccplex-cluster To: Mikko Perttunen , , , References: <1491223345-24386-1-git-send-email-mperttunen@nvidia.com> <1491223345-24386-2-git-send-email-mperttunen@nvidia.com> CC: , , From: Jon Hunter Message-ID: <87a034c6-ed81-4656-9593-b5708e65edb1@nvidia.com> Date: Mon, 3 Apr 2017 15:24:30 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <1491223345-24386-2-git-send-email-mperttunen@nvidia.com> X-Originating-IP: [10.26.11.77] X-ClientProxiedBy: UKMAIL101.nvidia.com (10.26.138.13) To UKMAIL101.nvidia.com (10.26.138.13) Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1337 Lines: 35 On 03/04/17 13:42, Mikko Perttunen wrote: > The Tegra186 CCPLEX_CLUSTER area contains memory-mapped > registers that initiate CPU frequency/voltage transitions. > > Signed-off-by: Mikko Perttunen > --- > .../arm/tegra/nvidia,tegra186-ccplex-cluster.txt | 22 ++++++++++++++++++++++ > 1 file changed, 22 insertions(+) > create mode 100644 Documentation/devicetree/bindings/arm/tegra/nvidia,tegra186-ccplex-cluster.txt > > diff --git a/Documentation/devicetree/bindings/arm/tegra/nvidia,tegra186-ccplex-cluster.txt b/Documentation/devicetree/bindings/arm/tegra/nvidia,tegra186-ccplex-cluster.txt > new file mode 100644 > index 000000000000..50cd615219e9 > --- /dev/null > +++ b/Documentation/devicetree/bindings/arm/tegra/nvidia,tegra186-ccplex-cluster.txt > @@ -0,0 +1,22 @@ > +NVIDIA Tegra CCPLEX_CLUSTER area > + > +Required properties: > +- compatible: Should contain one of the following: > + - "nvidia,tegra186-ccplex-cluster": for Tegra186 Nit pick ... any reason why we append 'cluster' here? The TRM just says the "CPU Complex" consists of two CPU clusters. So "nvidia,tegra186-cpu-complex" or "nvidia,tegra186-ccplex" seems fine. BTW, I do see references in the TRM to CCPLEX_CLUSTER0/1, but never CCPLEX_CLUSTER in reference to both. I think it is just CCPLEX AFAICT. Cheers Jon -- nvpublic