Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753773AbdDCPTy (ORCPT ); Mon, 3 Apr 2017 11:19:54 -0400 Received: from mail.kapsi.fi ([217.30.184.167]:53932 "EHLO mail.kapsi.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752946AbdDCPTu (ORCPT ); Mon, 3 Apr 2017 11:19:50 -0400 Subject: Re: [PATCH 2/3] dt-bindings: Add bindings for nvidia,tegra186-ccplex-cluster To: Jon Hunter , Mikko Perttunen , rjw@rjwysocki.net, viresh.kumar@linaro.org, thierry.reding@gmail.com References: <1491223345-24386-1-git-send-email-mperttunen@nvidia.com> <1491223345-24386-2-git-send-email-mperttunen@nvidia.com> <87a034c6-ed81-4656-9593-b5708e65edb1@nvidia.com> Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-tegra@vger.kernel.org From: Mikko Perttunen Message-ID: <40534e51-db02-6eb2-2426-b34a5ea0f61d@kapsi.fi> Date: Mon, 3 Apr 2017 18:19:49 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: <87a034c6-ed81-4656-9593-b5708e65edb1@nvidia.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 84.249.193.183 X-SA-Exim-Mail-From: cyndis@kapsi.fi X-SA-Exim-Scanned: No (on mail.kapsi.fi); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1541 Lines: 40 On 04/03/2017 05:24 PM, Jon Hunter wrote: > > On 03/04/17 13:42, Mikko Perttunen wrote: >> The Tegra186 CCPLEX_CLUSTER area contains memory-mapped >> registers that initiate CPU frequency/voltage transitions. >> >> Signed-off-by: Mikko Perttunen >> --- >> .../arm/tegra/nvidia,tegra186-ccplex-cluster.txt | 22 ++++++++++++++++++++++ >> 1 file changed, 22 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/arm/tegra/nvidia,tegra186-ccplex-cluster.txt >> >> diff --git a/Documentation/devicetree/bindings/arm/tegra/nvidia,tegra186-ccplex-cluster.txt b/Documentation/devicetree/bindings/arm/tegra/nvidia,tegra186-ccplex-cluster.txt >> new file mode 100644 >> index 000000000000..50cd615219e9 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/arm/tegra/nvidia,tegra186-ccplex-cluster.txt >> @@ -0,0 +1,22 @@ >> +NVIDIA Tegra CCPLEX_CLUSTER area >> + >> +Required properties: >> +- compatible: Should contain one of the following: >> + - "nvidia,tegra186-ccplex-cluster": for Tegra186 > > Nit pick ... any reason why we append 'cluster' here? The TRM just says > the "CPU Complex" consists of two CPU clusters. So > "nvidia,tegra186-cpu-complex" or "nvidia,tegra186-ccplex" seems fine. > > BTW, I do see references in the TRM to CCPLEX_CLUSTER0/1, but never > CCPLEX_CLUSTER in reference to both. I think it is just CCPLEX AFAICT. The reason was that the MMIO aperture is called "CCPLEX_CLUSTER" in the address map. But I agree it's not a very descriptive name. > > Cheers > Jon >