Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753499AbdDCR3F (ORCPT ); Mon, 3 Apr 2017 13:29:05 -0400 Received: from mail-it0-f54.google.com ([209.85.214.54]:35094 "EHLO mail-it0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752111AbdDCR3C (ORCPT ); Mon, 3 Apr 2017 13:29:02 -0400 MIME-Version: 1.0 In-Reply-To: <94F2FBAB4432B54E8AACC7DFDE6C92E37E58F104@ORSMSX110.amr.corp.intel.com> References: <20161217010425.GA140581@beast> <1AE640813FDE7649BE1B193DEA596E886CDFF348@SHSMSX101.ccr.corp.intel.com> <1AE640813FDE7649BE1B193DEA596E886CE6BD95@SHSMSX101.ccr.corp.intel.com> <94F2FBAB4432B54E8AACC7DFDE6C92E37E58F104@ORSMSX110.amr.corp.intel.com> From: Kees Cook Date: Mon, 3 Apr 2017 10:29:00 -0700 X-Google-Sender-Auth: nN1xBGGyeSVCsguvIvWvcz3DrSY Message-ID: Subject: Re: [PATCH] ACPICA: use designated initializers To: "Moore, Robert" Cc: "Zheng, Lv" , "linux-kernel@vger.kernel.org" , "Wysocki, Rafael J" , Len Brown , "linux-acpi@vger.kernel.org" , "devel@acpica.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 733 Lines: 19 On Fri, Mar 31, 2017 at 5:45 PM, Moore, Robert wrote: > Acpica is built with many compilers, even very old ones. It runs on at least 12 known operating systems, and very probably more. > > I'm sorry, but no, we are not going to start adding compiler-specific ifdefs/code in the base ACPICA code. > > I don't care what you do in the Linux-specific or gcc-specific headers, however. If this breaks a customer build, we (you) will hear about it rather quickly. Since the change is specific to the one place ACPICA uses an all-function-pointer structure, I made the change local: https://github.com/acpica/acpica/pull/248 would you rather this is in the .h files instead? -Kees -- Kees Cook Pixel Security