Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752935AbdDCRtx (ORCPT ); Mon, 3 Apr 2017 13:49:53 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:39626 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751757AbdDCRtv (ORCPT ); Mon, 3 Apr 2017 13:49:51 -0400 Date: Mon, 3 Apr 2017 18:19:12 +0100 From: Mark Brown To: Jeremy Linton Cc: linux-kernel@vger.kernel.org, lgirdwood@gmail.com, puck.chen@hisilicon.com, lee.jones@linaro.org Message-ID: <20170403171912.uv3b3sqfw5zaoyk7@sirena.org.uk> References: <20170403052843.12711-1-lintonrjeremy@gmail.com> <20170403052843.12711-3-lintonrjeremy@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="aresjukqgzzwjlih" Content-Disposition: inline In-Reply-To: <20170403052843.12711-3-lintonrjeremy@gmail.com> X-Cookie: Familiarity breeds attempt. User-Agent: NeoMutt/20161126 (1.7.1) X-SA-Exim-Connect-IP: 2001:470:1f1d:6b5::3 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH v2 2/2] regulator: hi655x: Bump parent pmic module use count X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: No (on mezzanine.sirena.org.uk); Unknown failure Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1160 Lines: 31 --aresjukqgzzwjlih Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Apr 03, 2017 at 12:28:43AM -0500, Jeremy Linton wrote: > The hi655x-regulator driver depends on the parent pmic/mfc > device driver but doesn't increase its use count. This results > in system crashes if the parent module is unloaded while the > regulators are still in use. Add explicit module get/put > calls to keep the parent from being unloaded. Once again, it is a complete hack to do this at the individual driver level. Please don't ignore review feedback. --aresjukqgzzwjlih Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAljihA8ACgkQJNaLcl1U h9Ak7Qf+LpA1sjaMDFrRqrPeKLZJzEXdC5WrKLSUoflDiGXQ3MTLgskAurIhJ5Dt 4NBPB5AKXIDziOv34MjNLKOYk9xve8XMTIJCtVh68dvjacTy0Yf2LFp4NCPuuExB WCrE8GXfQMXhvDLox151mFHDJ9AmnN/QuKl2+ECDfZM9cdYciSAYqljse92BIuph uZnFCfP+3i+4X+IEFWWBPlI9lhQa4Cohman9IYUfc4Mv6uOw4bircdl665YDYTZP UkGTCdvNEfCt8SmjLkQov3U9V8bs/ciSjYQdYw+xYUa8WCiqRj2AgQjlYT3BaTzb oBYRQiplkkxsJHHfAq7vNcjuGpm74A== =80hj -----END PGP SIGNATURE----- --aresjukqgzzwjlih--