Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753411AbdDCSLY (ORCPT ); Mon, 3 Apr 2017 14:11:24 -0400 Received: from mx1.redhat.com ([209.132.183.28]:45960 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753330AbdDCSLX (ORCPT ); Mon, 3 Apr 2017 14:11:23 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com B1E0F3D945 Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=mst@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com B1E0F3D945 Date: Mon, 3 Apr 2017 21:11:16 +0300 From: "Michael S. Tsirkin" To: Mike Galbraith Cc: Christoph Hellwig , Thorsten Leemhuis , virtio-dev@lists.oasis-open.org, Linux Kernel Mailing List , rjones@redhat.com Subject: Re: Random guest crashes since 5c34d002dcc7 ("virtio_pci: use shared interrupts for virtqueues") Message-ID: <20170403210931-mutt-send-email-mst@kernel.org> References: <1490768602.5950.25.camel@gmx.de> <20170329230936-mutt-send-email-mst@kernel.org> <1490843414.4167.11.camel@gmx.de> <1490858435.4696.25.camel@gmx.de> <20170331041959-mutt-send-email-mst@kernel.org> <20170331032231.GA2471@redhat.com> <20170331082049.GA4485@lst.de> <20170331194416-mutt-send-email-mst@kernel.org> <20170403141823.GA24747@lst.de> <1491242192.5638.111.camel@gmx.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1491242192.5638.111.camel@gmx.de> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Mon, 03 Apr 2017 18:11:22 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 663 Lines: 20 On Mon, Apr 03, 2017 at 07:56:32PM +0200, Mike Galbraith wrote: > On Mon, 2017-04-03 at 16:18 +0200, Christoph Hellwig wrote: > > Mike, > > > > can you try the patch below? > > No more spinning kworker woes, but I still have a warning on hibernate, > threadirqs invariant. I'm also seeing intermittent post hibernate hang > funnies in virgin source +- this patch, and without threadirqs. > > [ 110.223953] WARNING: CPU: 5 PID: 452 at drivers/pci/msi.c:1261 pci_irq_vector+0xb1/0xe0 > > -Mike I just sent a patch fixing that. However I think we want to print a message when MSI fails to work so we know guest is falling back on legacy interrupts. -- MST