Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753892AbdDCSid (ORCPT ); Mon, 3 Apr 2017 14:38:33 -0400 Received: from iolanthe.rowland.org ([192.131.102.54]:45114 "HELO iolanthe.rowland.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1752400AbdDCSia (ORCPT ); Mon, 3 Apr 2017 14:38:30 -0400 Date: Mon, 3 Apr 2017 14:38:29 -0400 (EDT) From: Alan Stern X-X-Sender: stern@iolanthe.rowland.org To: Greg Kroah-Hartman cc: "Gustavo A. R. Silva" , Felipe Balbi , Peter Chen , Chunfeng Yun , Mathias Nyman , , , Peter Senna Tschudin Subject: Re: [PATCH] usb: misc: add missing continue and refactor code In-Reply-To: <20170403175738.GA12790@kroah.com> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 511 Lines: 14 On Mon, 3 Apr 2017, Greg Kroah-Hartman wrote: > On Mon, Apr 03, 2017 at 09:39:53AM -0500, Gustavo A. R. Silva wrote: > > -Code refactoring to make the flow easier to follow. > > -Add missing 'continue' for case USB_ENDPOINT_XFER_INT. > > Don't do multiple things in the same patch, please make these multiple > patches. And do the "add missing continue" first, so it can be > backported to other kernels easier please. Also, make sure your patch does not contain gratuitous whitespace changes. Alan Stern