Message-ID: <1491246400.27353.59.camel@perches.com>
Subject: Re: [PATCH v1] checkpatch: test missing initial blank line in block
 comment
From: Joe Perches <joe@perches.com>
To: Hugues Fruchet <hugues.fruchet@st.com>,
        Andy Whitcroft <apw@canonical.com>
Cc: linux-kernel@vger.kernel.org
Date: Mon, 03 Apr 2017 12:06:40 -0700
In-Reply-To: <1491206895-24332-2-git-send-email-hugues.fruchet@st.com>
References: <1491206895-24332-1-git-send-email-hugues.fruchet@st.com>
         <1491206895-24332-2-git-send-email-hugues.fruchet@st.com>
Content-Type: text/plain; charset="ISO-8859-1"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 829
Lines: 33

On Mon, 2017-04-03 at 10:08 +0200, Hugues Fruchet wrote:
> Warn when block comments are not starting with blank comment:
> 
> /* multiple lines
>  * block comment,
>  * => warning
>  */
> 
> /*
>  * multiple lines
>  * block comment,
>  * => no warning
>  */
> 
> Exception made for networking files where rule is the
> exact opposite.

I recall there was some reason I didn't do this
when adding the block comment code, but I don't
recall what it was.  Perhaps it was the initial
line of files.

Maybe your $realline > 2 test fixes it.  Maybe not.
Dunno.

If you run this against the entire kernel code
using a unique test type and not BLOCK_COMMENT_STYLE
are there any false positives?

Maybe test with something like:

$ git ls-files -- "*.[ch]" | \
  xargs --max-args 20 ./scripts/checkpatch.pl -f --types=<your_unique_test>