Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752346AbdDDBQd (ORCPT ); Mon, 3 Apr 2017 21:16:33 -0400 Received: from bombadil.infradead.org ([65.50.211.133]:41796 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751668AbdDDBQb (ORCPT ); Mon, 3 Apr 2017 21:16:31 -0400 Date: Mon, 3 Apr 2017 18:16:28 -0700 From: Darren Hart To: =?utf-8?B?TWljaGHFgiBLxJlwaWXFhA==?= Cc: Jonathan Woithe , Andy Shevchenko , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 11/11] platform/x86: fujitsu-laptop: remove redundant fields from struct fujitsu_bl Message-ID: <20170404011628.GA16584@fury> References: <20170330103509.32509-1-kernel@kempniu.pl> <20170330103509.32509-12-kernel@kempniu.pl> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20170330103509.32509-12-kernel@kempniu.pl> User-Agent: Mutt/1.7.1 (2016-10-04) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 643 Lines: 16 On Thu, Mar 30, 2017 at 12:35:09PM +0200, Michał Kępień wrote: > The dev field of struct fujitsu_bl is assigned in acpi_fujitsu_bl_add(), > but never used afterwards. brightness_changed is set in get_lcd_level() > and then its value is only printed in a debug message, so it does not > influence execution flow. Remove both fields as they are redundant. Indeed, once that was removed from the platform device and the corresponding sysfs entries were eliminated, we can drop it: 78b2602 platform/x86: fujitsu-laptop: remove backlight-related attributes from the platform device :-) -- Darren Hart VMware Open Source Technology Center