Date: Fri, 30 May 2003 00:19:05 +1000
Subject: Re: buffer_head.b_bsize type
Content-Type: text/plain; charset=US-ASCII; format=flowed
Mime-Version: 1.0 (Apple Message framework v552)
Cc: William Lee Irwin III <wli@holomorphy.com>, linux-kernel@vger.kernel.org,
       trivial@rustcorp.com.au
To: viro@parcelfarce.linux.theplanet.co.uk
From: Stewart Smith <stewartsmith@mac.com>
In-Reply-To: <20030529111517.GP14138@parcelfarce.linux.theplanet.co.uk>
Message-Id: <80FB28EB-91E0-11D7-9488-00039346F142@mac.com>
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org

On Thursday, May 29, 2003, at 09:15  PM, 
viro@parcelfarce.linux.theplanet.co.uk wrote:
>> Could we go the other way and make all users of b_size use unsigned?
>
> Who the hell cares?  Size of buffer does not exceed the page size.
> Unless you can show a platform with 2Gb pages...

I would argue the same that the size of a buffer should never be able 
to be negative and the structure says this but the rest of the code 
does not. (Theoretically) if a negative size was asked for, then we'd 
actually try to allocate a large amount of memory for the buffer, 
possibly causing badness somewhere along the line.

Any maybe we shouldn't make it too hard for archs with 2GB pages :) 
It'll probably happen in 20 years. :)

------------------------------
Stewart Smith
stewartsmith@mac.com
Ph: +61 4 3884 4332
ICQ: 6734154
http://www.flamingspork.com/       http://www.linux.org.au

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/