Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752158AbdDDDJB (ORCPT ); Mon, 3 Apr 2017 23:09:01 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:32799 "EHLO out1-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751406AbdDDDI7 (ORCPT ); Mon, 3 Apr 2017 23:08:59 -0400 X-ME-Sender: X-Sasl-enc: JzlkVLLc3qIFHnusrn9idX+V5V6cQSYqH22/osF5Q4LJ 1491275338 From: Nikolaus Rath To: Masaki Ota , linux-kernel , linux-input@vger.kernel.org Subject: Re: [PATCH 1/2] Alps HID I2C T4 device support References: <20170403121559.1397-1-clabbe.montjoie@gmail.com> <20170403121559.1397-6-clabbe.montjoie@gmail.com> <64bd824c-2d09-3c8c-d35d-06d3808713b2@ladisch.de> References: <20170330025317.4093-2-masaki.ota@jp.alps.com> Date: Mon, 03 Apr 2017 20:08:57 -0700 In-Reply-To: <64bd824c-2d09-3c8c-d35d-06d3808713b2@ladisch.de> (Clemens Ladisch's message of "Mon, 3 Apr 2017 14:55:14 +0200") Message-ID: <87zifw7tti.fsf_-_@vostro.rath.org> User-Agent: Gnus/5.130014 (Ma Gnus v0.14) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v34396lZ010678 Content-Length: 940 Lines: 27 Hi Ota, > -Support Alps HID I2C T4 Touchpad device. > -Laptop names that use this Touchpad:HP Zbook Studio, Elitebook Folio G1, Elitebook 1030 G1, Elitebook 1040 G3 > > Signed-off-by: Masaki Ota > --- > drivers/hid/hid-alps.c | 500 +++++++++++++++++++++++++++++++++++++++---------- > drivers/hid/hid-core.c | 3 +- > drivers/hid/hid-ids.h | 1 + > 3 files changed, 403 insertions(+), 101 deletions(-) I tried your patch on an HP Elitebook, but with rather limited success. Before, I was able to use the touchpad in limited fashion (https://bugs.freedesktop.org/show_bug.cgi?id=100345). With your patch (applied on top of 4.10), the touchpad no longer reacts at all. That said, I didn't find a patch 2/2 anywhere.. is there something missing? Thanks, -Nikolaus -- GPG Fingerprint: ED31 791B 2C5C 1613 AF38 8B8A D113 FCAC 3C4E 599F »Time flies like an arrow, fruit flies like a Banana.«