Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750999AbdDDEDE (ORCPT ); Tue, 4 Apr 2017 00:03:04 -0400 Received: from mout.gmx.net ([212.227.15.18]:51218 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750892AbdDDEDC (ORCPT ); Tue, 4 Apr 2017 00:03:02 -0400 Message-ID: <1491278572.5198.28.camel@gmx.de> Subject: Re: Random guest crashes since 5c34d002dcc7 ("virtio_pci: use shared interrupts for virtqueues") From: Mike Galbraith To: "Michael S. Tsirkin" Cc: Christoph Hellwig , Thorsten Leemhuis , virtio-dev@lists.oasis-open.org, Linux Kernel Mailing List , rjones@redhat.com Date: Tue, 04 Apr 2017 06:02:52 +0200 In-Reply-To: <20170403210931-mutt-send-email-mst@kernel.org> References: <1490768602.5950.25.camel@gmx.de> <20170329230936-mutt-send-email-mst@kernel.org> <1490843414.4167.11.camel@gmx.de> <1490858435.4696.25.camel@gmx.de> <20170331041959-mutt-send-email-mst@kernel.org> <20170331032231.GA2471@redhat.com> <20170331082049.GA4485@lst.de> <20170331194416-mutt-send-email-mst@kernel.org> <20170403141823.GA24747@lst.de> <1491242192.5638.111.camel@gmx.de> <20170403210931-mutt-send-email-mst@kernel.org> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.16.5 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:MQoYw0wQfR+0LuqaM5nW17qPDhDeaxOaLXv1+vAGIlhdxfC+nq8 3aa9GBwCD2Lbc8IysxbAGi4IoHffWBtAF8Q78kmRFL7+gv87bvZVT8QhYowMcz97W5L1IHG AHb9d9zrC5g1iOp7AkKYJ7+AIz5IV1Osrl0BJq9qb3Mkc9e8Ax1Xy4jE4ljaLiefEWPmCl0 1oRmI6ucoREOuwNHTEjHA== X-UI-Out-Filterresults: notjunk:1;V01:K0:SH6vnaouqkc=:T3IeUCT6qvXQgenW3o+qtN LtWkUjTM48tn4FFm+73BFyICi3Zh0au1Uu6BfXnbZq2qc3glbwc+BOlSm+iJ3/xO0tKOKnhvG C3M8ueJBF0hgiU7z3gYsEhzb9HxZ+YyvLDLV+jVsau/Q7cjyQBqccBE1kryTbamUhtiAi+Mi/ jalfo0xN6kL/GnqLgBQIH6qktSgiHWES20HwPHSq0EX+F7SFPIyzlj6lz6jmfvhlRa/H5OAbN sK+UPXh2Pg8Ou4iohFhkoqxI5YIUx7kItEPSUB286+7r5Fno41lXy4B9MZobGMcAVMfWSKrDM 0hFSDIMIjUTd7dKDNoZlgUK7gMqdH1mZweftN5lxKO/doKuzPK2KPZGayxbMsrF5DD9HlDGRE s24uKAZhRdG/PxqR/DrDR4AI/F+wP8gfAS7srXYkw5X8qjSH1efEHaFesnoeiGmOWIFe/GLLg E1GyhjM7glzfwqO8+87HNIu9hved4nMmb1DPhrsbhVI0PdyKXKKtl5AJk9t5EANCp6jQSpwrn VKvdYOj2WGOKhT2WfP0+AtZJrnAB8LJu3S7GHzxhtl4d6sUSSnZk50n0AzXDQai2LOKFvYr0W 8WrMy17Jrf/NH0CD+ZguOm3Uf4TzxCil2jKpLjkEVbAqobPcAKFwp04WUyPqKNlbfe3Hvu759 QgrnEY26jpfhqBDIIibPRnDI5pmWkqF+E/+fMdcElwdj3HCvQTR5Fb9HNCEgRlGYC1GaoGxbH 8ttM9Xcc3wqVTes45oQsZWq2SjiMzbziGNrmmzTeZYrkdr+7CZtDUArRIHQLHvHPpYNLlg7o8 NiLu7+3 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1290 Lines: 33 On Mon, 2017-04-03 at 21:11 +0300, Michael S. Tsirkin wrote: > On Mon, Apr 03, 2017 at 07:56:32PM +0200, Mike Galbraith wrote: > > On Mon, 2017-04-03 at 16:18 +0200, Christoph Hellwig wrote: > > > Mike, > > > > > > can you try the patch below? > > > > No more spinning kworker woes, but I still have a warning on hibernate, > > threadirqs invariant. I'm also seeing intermittent post hibernate hang > > funnies in virgin source +- this patch, and without threadirqs. > > > > [ 110.223953] WARNING: CPU: 5 PID: 452 at drivers/pci/msi.c:1261 pci_irq_vector+0xb1/0xe0 > > > > > > -Mike > > I just sent a patch fixing that. > However I think we want to print a message when MSI fails to work so we > know guest is falling back on legacy interrupts. The warning persists. [ 137.656423] WARNING: CPU: 1 PID: 535 at drivers/pci/msi.c:1261 pci_irq_vector+0xb1/0xe0 WRT the post hibernate hang business, that is apparently not part of the 4.11 woes (at least not solely), as 4.10.8 did not survive a 10 hibernate cycle loop. RT is better at reproducing trouble (shrug, it frequently is), but it matters not whether I'm running 4.10, master or master-rt, they will all hang. WRT gripe, I wedged virtio_pci-fix-msix-vector-tracking-on-cleanup in on top, but it wasn't impressed. -Mike