Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752248AbdDDGQl (ORCPT ); Tue, 4 Apr 2017 02:16:41 -0400 Received: from mail-vk0-f53.google.com ([209.85.213.53]:34894 "EHLO mail-vk0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752040AbdDDGQj (ORCPT ); Tue, 4 Apr 2017 02:16:39 -0400 MIME-Version: 1.0 In-Reply-To: <20170402172949.GA1479@project> References: <20170327100646.GA8128@project> <2bec8c26-f33c-d331-aa97-047871b4cc57@kernel.org> <20170402172949.GA1479@project> From: Matt Ranostay Date: Mon, 3 Apr 2017 23:16:37 -0700 Message-ID: Subject: Re: [PATCH] IIO: bmp280-core.c: fix error in humidity calculation To: Andreas Klinger Cc: Linus Walleij , Jonathan Cameron , Matt Ranostay , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald , ddvlad@gmail.com, Akinobu Mita , Wei Yongjun , Aniroop Mathur , "linux-iio@vger.kernel.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1512 Lines: 45 On Sun, Apr 2, 2017 at 10:29 AM, Andreas Klinger wrote: > Linus Walleij schrieb am Sun, 02. Apr 16:56: >> On Sun, Apr 2, 2017 at 11:32 AM, Jonathan Cameron wrote: >> > On 27/03/17 11:06, Andreas Klinger wrote: >> >> While calculating the compensation of the humidity there are negative >> >> values interpreted as unsigned because of unsigned variables used. >> >> These values need to be casted to signed as indicated by the documentation >> >> of the sensor. >> >> >> >> Signed-off-by: Andreas Klinger >> > >> > Looks superficially right to me, but would like an Ack from Linus Walleij. >> >> I didn't work on these calculations, only infrastructure for the driver >> but FWIW: >> Acked-by: Linus Walleij >> >> Matt Ranostay @Intel is the person you probably want to ACK it though, >> he added the humidity calculations :) > > It just turned out that there must be another error in the calculation. I'll fix > and test it first. > > When i'm done i'll send a new version of the patch. > Ok will hold off till review till the next patchset... BTW this datasheet's calculations made my eyes bleed so it is quiet likely it has bugs... Thanks, Matt > Andreas > >> >> Yours, >> Linus Walleij > > -- > -- > To unsubscribe from this list: send the line "unsubscribe linux-iio" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html