Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753317AbdDDIjw (ORCPT ); Tue, 4 Apr 2017 04:39:52 -0400 Received: from mail-wr0-f179.google.com ([209.85.128.179]:35248 "EHLO mail-wr0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752172AbdDDIfB (ORCPT ); Tue, 4 Apr 2017 04:35:01 -0400 Date: Tue, 4 Apr 2017 09:34:57 +0100 From: Lee Jones To: Steve Twiss Cc: LINUX-KERNEL , DEVICETREE , Dmitry Torokhov , Eduardo Valentin , Guenter Roeck , LINUX-INPUT , LINUX-PM , LINUX-WATCHDOG , Liam Girdwood , Mark Brown , Mark Rutland , Rob Herring , Support Opensource , Wim Van Sebroeck , Zhang Rui Subject: Re: [PATCH V7 4/7] mfd: da9061: MFD core support Message-ID: <20170404083457.bcpqw6gv6rzhevrp@dell> References: <8987877cc54940358c5b7a65ca003cedc5586f0d.1490712213.git.stwiss.opensource@diasemi.com> <20170403141214.q6ndii6c47pqfqx6@dell> <6ED8E3B22081A4459DAC7699F3695FB7018CD6B183@SW-EX-MBX02.diasemi.com> <20170403143049.qyi4dagwi4cdenok@dell> <6ED8E3B22081A4459DAC7699F3695FB7018CD6B207@SW-EX-MBX02.diasemi.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <6ED8E3B22081A4459DAC7699F3695FB7018CD6B207@SW-EX-MBX02.diasemi.com> User-Agent: Mutt/1.6.2-neo (2016-08-21) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1499 Lines: 51 On Mon, 03 Apr 2017, Steve Twiss wrote: > On 03 April 2017 15:31, Lee Jones wrote: > > > Subject: Re: [PATCH V7 4/7] mfd: da9061: MFD core support > > > > On Mon, 03 Apr 2017, Steve Twiss wrote: > > > On 03 April 2017 15:12, Lee Jones wrote: > > > > > > > > @@ -475,7 +855,25 @@ static int da9062_i2c_probe(struct i2c_client *i2c, > > > > > return -EINVAL; > > > > > } > > > > > > > > > > - chip->regmap = devm_regmap_init_i2c(i2c, &da9062_regmap_config); > > > > > + switch (chip->chip_type) { > > > > > + case(COMPAT_TYPE_DA9061): > > > > > > > > Brackets around the case value? > > > > > > > > That's a new one on me. > > > > > > Hm. Do you want me to resend it without braces? > > > > Yes please. And a space after the 'case'. > > Hi Lee, > > I have resent PATCH V7 to change "case(X):" to be "case X:". > - Removed brackets surrounding case statements for > case COMPAT_TYPE_DA9061: > case COMPAT_TYPE_DA9062: Okay, good. > New patch is here: > https://lkml.org/lkml/2017/4/3/462 > > The patch it is called by the same title "[PATCH V7 4/7] mfd: da9061: MFD core support". > I've not updated the whole patch-set or changed the patch version number from V7. I don't see it in my inbox? You should always change the version, or things get confusing. Even if it's a small change, you can differentiate by v7.1 or similar. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog