Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753589AbdDDLOk (ORCPT ); Tue, 4 Apr 2017 07:14:40 -0400 Received: from gateway31.websitewelcome.com ([192.185.143.40]:48186 "EHLO gateway31.websitewelcome.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753793AbdDDLNH (ORCPT ); Tue, 4 Apr 2017 07:13:07 -0400 Date: Tue, 04 Apr 2017 06:12:37 -0500 Message-ID: <20170404061237.Horde.DFyuMUPIoie1ZXD61kdv01c@gator4166.hostgator.com> From: "Gustavo A. R. Silva" To: Felipe Balbi Cc: Alan Stern , Greg Kroah-Hartman , Peter Chen , Chunfeng Yun , Mathias Nyman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Peter Senna Tschudin Subject: Re: [PATCH 2/2] usb: misc: refactor code References: <20170403195042.GA12225@embeddedgus> <87fuhoipny.fsf@linux.intel.com> In-Reply-To: <87fuhoipny.fsf@linux.intel.com> User-Agent: Horde Application Framework 5 Content-Type: text/plain; charset=utf-8; format=flowed; DelSp=Yes MIME-Version: 1.0 Content-Disposition: inline X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 108.167.133.22 X-Exim-ID: 1cvMO5-000V7A-Nq X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: gator4166.hostgator.com [108.167.133.22]:39321 X-Source-Auth: garsilva@embeddedor.com X-Email-Count: 2 X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2416 Lines: 89 Hello, Quoting Felipe Balbi : > Hi, > > "Gustavo A. R. Silva" writes: >> Code refactoring to make the flow easier to follow. >> >> Cc: Alan Stern >> Cc: Greg Kroah-Hartman >> Signed-off-by: Gustavo A. R. Silva >> --- >> drivers/usb/misc/usbtest.c | 67 >> +++++++++++++++++++++------------------------- >> 1 file changed, 30 insertions(+), 37 deletions(-) >> >> diff --git a/drivers/usb/misc/usbtest.c b/drivers/usb/misc/usbtest.c >> index 7bfb6b78..382491e 100644 >> --- a/drivers/usb/misc/usbtest.c >> +++ b/drivers/usb/misc/usbtest.c >> @@ -124,18 +124,32 @@ static struct usb_device >> *testdev_to_usbdev(struct usbtest_dev *test) >> >> >> /*-------------------------------------------------------------------------*/ >> >> +static inline void endpoint_update(int edi, >> + struct usb_host_endpoint **in, >> + struct usb_host_endpoint **out, >> + struct usb_host_endpoint *e) >> +{ >> + if (edi) { >> + if (!*in) >> + *in = e; >> + } else { >> + if (!*out) >> + *out = e; >> + } >> +} >> + >> static int >> get_endpoints(struct usbtest_dev *dev, struct usb_interface *intf) >> { >> - int tmp; >> - struct usb_host_interface *alt; >> - struct usb_host_endpoint *in, *out; >> - struct usb_host_endpoint *iso_in, *iso_out; >> - struct usb_host_endpoint *int_in, *int_out; >> - struct usb_device *udev; >> + int tmp; >> + struct usb_host_interface *alt; >> + struct usb_host_endpoint *in, *out; >> + struct usb_host_endpoint *iso_in, *iso_out; >> + struct usb_host_endpoint *int_in, *int_out; >> + struct usb_device *udev; > > unnecessary change > >> >> for (tmp = 0; tmp < intf->num_altsetting; tmp++) { >> - unsigned ep; >> + unsigned ep; > > unnecessary change > >> >> in = out = NULL; >> iso_in = iso_out = NULL; >> @@ -150,48 +164,27 @@ get_endpoints(struct usbtest_dev *dev, struct >> usb_interface *intf) >> * ignore other endpoints and altsettings. >> */ >> for (ep = 0; ep < alt->desc.bNumEndpoints; ep++) { >> - struct usb_host_endpoint *e; >> + struct usb_host_endpoint *e; > > unnecessary change > I already sent the version 2 of this patch: https://lkml.org/lkml/2017/4/3/856 Thanks -- Gustavo A. R. Silva