Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753469AbdDDM2v (ORCPT ); Tue, 4 Apr 2017 08:28:51 -0400 Received: from foss.arm.com ([217.140.101.70]:43824 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751505AbdDDM2u (ORCPT ); Tue, 4 Apr 2017 08:28:50 -0400 Date: Tue, 4 Apr 2017 13:28:29 +0100 From: Mark Rutland To: Ganapatrao Kulkarni Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Will.Deacon@arm.com, catalin.marinas@arm.com, acme@kernel.org, alexander.shishkin@linux.intel.com, peterz@infradead.org, mingo@redhat.com, jnair@caviumnetworks.com, gpkulkarni@gmail.com Subject: Re: [PATCH 3/3] perf tool, arm64, thunderx2: Add implementation defined events for ThunderX2 Message-ID: <20170404122828.GB8551@leverpostej> References: <1491291403-29893-1-git-send-email-ganapatrao.kulkarni@cavium.com> <1491291403-29893-4-git-send-email-ganapatrao.kulkarni@cavium.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1491291403-29893-4-git-send-email-ganapatrao.kulkarni@cavium.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1751 Lines: 41 On Tue, Apr 04, 2017 at 01:06:43PM +0530, Ganapatrao Kulkarni wrote: > This is not a full event list, but a short list of useful events. > > Signed-off-by: Ganapatrao Kulkarni > --- > tools/perf/pmu-events/arch/arm64/mapfile.csv | 2 + > .../arm64/thunderx2/implementation-defined.json | 72 ++++++++++++++++++++++ > 2 files changed, 74 insertions(+) > create mode 100644 tools/perf/pmu-events/arch/arm64/mapfile.csv > create mode 100644 tools/perf/pmu-events/arch/arm64/thunderx2/implementation-defined.json > > diff --git a/tools/perf/pmu-events/arch/arm64/mapfile.csv b/tools/perf/pmu-events/arch/arm64/mapfile.csv > new file mode 100644 > index 0000000..ba30e43 > --- /dev/null > +++ b/tools/perf/pmu-events/arch/arm64/mapfile.csv > @@ -0,0 +1,2 @@ > +Family-model,Version,Filename,EventType > +0x00000000420f5161,v1,thunderx2,core > diff --git a/tools/perf/pmu-events/arch/arm64/thunderx2/implementation-defined.json b/tools/perf/pmu-events/arch/arm64/thunderx2/implementation-defined.json > new file mode 100644 > index 0000000..360e084 > --- /dev/null > +++ b/tools/perf/pmu-events/arch/arm64/thunderx2/implementation-defined.json > @@ -0,0 +1,72 @@ > +[ > + { > + "PublicDescription": "Attributable Level 1 data cache access, read", > + "EventCode": "0x40", > + "EventName": "l1d_cache_access_read", > + "BriefDescription": "l1d cache access, read", > + "CPU" :"armv8_pmuv3_0" Please let's not hard-code the name like this. Surely we can get rid of this? The kernel doesn't currently name PMUs as armv8_pmuv3_*, and as that can differ across DT/ACPI and in big.LITTLE, I don't think it makes sense to try to rely one particular string regardless. Thanks, Mark.