Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753617AbdDDNYZ (ORCPT ); Tue, 4 Apr 2017 09:24:25 -0400 Received: from fllnx209.ext.ti.com ([198.47.19.16]:12232 "EHLO fllnx209.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753502AbdDDNYX (ORCPT ); Tue, 4 Apr 2017 09:24:23 -0400 Subject: Re: [PATCH v3] phy: rcar-gen3-usb2: fix implementation for runtime PM To: Yoshihiro Shimoda References: <1489448261-4477-1-git-send-email-yoshihiro.shimoda.uh@renesas.com> CC: "linux-kernel@vger.kernel.org" , "linux-renesas-soc@vger.kernel.org" From: Kishon Vijay Abraham I Message-ID: <3af8a3d4-9801-b015-ed83-7f0a190cb767@ti.com> Date: Tue, 4 Apr 2017 18:53:52 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 918 Lines: 29 Hi, On Tuesday 04 April 2017 05:06 PM, Yoshihiro Shimoda wrote: > Hi Kishon, > >> From: Yoshihiro Shimoda, Sent: Tuesday, March 14, 2017 8:38 AM >> >> This patch fixes an issue that this driver doesn't take care of the runtime >> PM. This code assumed that devm_phy_create() called pm_runtime_enable(dev), >> but it misunderstood the dev_phy_create()'s specification. >> This driver should call its own pm_runtime_enable() before dev_phy_create(). >> >> Fixes: f3b5a8d9b50d ("phy: rcar-gen3-usb2: Add R-Car Gen3 USB2 PHY driver") >> Signed-off-by: Yoshihiro Shimoda >> --- >> Changes from v2: >> - revise the commit log (s/pm_runtime_pm/pm_runtime_enable) >> >> Changes from v1: >> - revise the commit log (s/the own/its own/) >> - simplify return code in probe(). > > I'm afraid but would you review this patch? sure, the patch looks good. merged now, thanks. -Kishon