Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754293AbdDDOSi (ORCPT ); Tue, 4 Apr 2017 10:18:38 -0400 Received: from mout.gmx.net ([212.227.17.21]:54111 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752893AbdDDOSN (ORCPT ); Tue, 4 Apr 2017 10:18:13 -0400 Message-ID: <1491315482.5239.11.camel@gmx.de> Subject: Re: Random guest crashes since 5c34d002dcc7 ("virtio_pci: use shared interrupts for virtqueues") From: Mike Galbraith To: "Michael S. Tsirkin" Cc: Christoph Hellwig , Thorsten Leemhuis , virtio-dev@lists.oasis-open.org, Linux Kernel Mailing List , rjones@redhat.com Date: Tue, 04 Apr 2017 16:18:02 +0200 In-Reply-To: <20170404163725-mutt-send-email-mst@kernel.org> References: <1490843414.4167.11.camel@gmx.de> <1490858435.4696.25.camel@gmx.de> <20170331041959-mutt-send-email-mst@kernel.org> <20170331032231.GA2471@redhat.com> <20170331082049.GA4485@lst.de> <20170331194416-mutt-send-email-mst@kernel.org> <20170403141823.GA24747@lst.de> <1491242192.5638.111.camel@gmx.de> <20170403210931-mutt-send-email-mst@kernel.org> <1491278572.5198.28.camel@gmx.de> <20170404163725-mutt-send-email-mst@kernel.org> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.16.5 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:G8hxv3eqYEybrNkvhX3vldqk0CxQO8oH4hBEyexZe3GvJ7bt14U Y11nuiYQB5gjtbklfM3ouOCpQQqcWgb1dmGBJFpUsHhyo6c9VrY7WdzXOUWPSiws02h8Vv5 xhOZgUcIZbJThGEov8pC4mcmszDYNnYoDeMkn34G8cZplFKZ/kQ0fFBKyr/DaSmCXxeILu0 bE9/1yAg3hne4iqkeuN2w== X-UI-Out-Filterresults: notjunk:1;V01:K0:PRpdkFkdEQI=:PcmTFXMQMYAeQYkcN3hohO qo6y3fgJtjkGjKcJrHPtgcSL16EyE+xIzhI6bxYNZKZdiBKM6DWSErOfVlpaFT7/0D7pwchVk oDwApgRj0RR3S6wg2yqRwfW6Y4EfedDUzbWvMUohxoXsmBnVhKITDKj6dzCf8rv7IdMTsAWp6 t16saXdKpcQCWDG4As37bjVIG7tYqF1d9NMjVOlxg7MDUfStO3nJpGyYYFCfOL0xn3r6vf73G 5SE10x9ytwmnyoS4rOcIPaVGKDOZEpGGb+FS241Q6gmhKZI311syIXqOxwmlDtE/RGOqO9T+i 58XcSE34aqgCT0AxDljRBeIBMNkWHHfEgEEqg/m8X7Xox4L7JPRo/l3hWfXq5+0bCDtmnjFdP t0XQrvJpUj/5JmHzmZydjxsE4GKiEDcge1t90O8vJGefDEWSe7QmCYAaKbeydz4YHfruobS0K FQmbESu2frdNudQ2YZBWe74nZlu0BJoaE2BKqlVaXWkAeQcdtJNBTSPSr69mbSEr3QRx3R+fr RaPa3/tyGCbY2grtr0epi5d28QeV3cWpuexR7PsHYT7aUydDCJCrwN+IFfFBN/ygzo2G2qH4c D4QHwA2TxHTtiLLtr/pTJBbjI35LpRs3Ae8NMt90mjp8zlTR2Rt8GL01GQHT074KIWsGGISr3 dEFM/AvvtF19kDMJ0uo0bSRI5wQeNphJ7FkiYQ8SMPjDlAkRQgqer54Fn0MEssOmsx674KOeb MxksWIzr2ufAQ277Q3P4z44w6//cVlFS/udwDaTGmNCsiEx9b/QfZRXKJd8pGSwR++izUU2qk q4eBLRo Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 4470 Lines: 67 On Tue, 2017-04-04 at 16:38 +0300, Michael S. Tsirkin wrote: > On Tue, Apr 04, 2017 at 06:02:52AM +0200, Mike Galbraith wrote: > > On Mon, 2017-04-03 at 21:11 +0300, Michael S. Tsirkin wrote: > > > On Mon, Apr 03, 2017 at 07:56:32PM +0200, Mike Galbraith wrote: > > > > On Mon, 2017-04-03 at 16:18 +0200, Christoph Hellwig wrote: > > > > > Mike, > > > > > > > > > > can you try the patch below? > > > > > > > > No more spinning kworker woes, but I still have a warning on > > > > hibernate, > > > > threadirqs invariant. I'm also seeing intermittent post > > > > hibernate hang > > > > funnies in virgin source +- this patch, and without threadirqs. > > > > > > > > [ 110.223953] WARNING: CPU: 5 PID: 452 at > > > > drivers/pci/msi.c:1261 pci_irq_vector+0xb1/0xe0 > > > > > > > > > > -Mike > > > > > > I just sent a patch fixing that. > > > However I think we want to print a message when MSI fails to work > > > so we > > > know guest is falling back on legacy interrupts. > > > > The warning persists. > > > > [ 137.656423] WARNING: CPU: 1 PID: 535 at drivers/pci/msi.c:1261 > > pci_irq_vector+0xb1/0xe0 > > Can you post the rest of the backtrace? Is it still in the console? This is from a dump of post hibernate loop dying vbox I captured and squirreled away, so pid is different. I'm not absolutely certain that I didn't have my local patch set re-applied when I did this, so I'll rebuild in the a.m.. My stuff is unrelated, so this should be fine. [ 328.475988] ------------[ cut here ]------------ [ 328.476002] WARNING: CPU: 6 PID: 313 at drivers/pci/msi.c:1261 pci_irq_vector+0xb1/0xe0 [ 328.476003] Modules linked in: fuse(E) ebtable_filter(E) ebtables(E) nf_log_ipv6(E) xt_pkttype(E) nf_log_ipv4(E) nf_log_common(E) xt_LOG(E) xt_limit(E) rpcsec_gss_krb5(E) nfsv4(E) dns_resolver(E) nfs(E) fscache(E) af_packet(E) iscsi_ibft(E) iscsi_boot_sysfs(E) ip6t_REJECT(E) xt_tcpudp(E) nf_conntrack_ipv6(E) nf_defrag_ipv6(E) ip6table_raw(E) ipt_REJECT(E) iptable_raw(E) xt_CT(E) iptable_filter(E) ip6table_mangle(E) nf_conntrack_netbios_ns(E) nf_conntrack_broadcast(E) nf_conntrack_ipv4(E) nf_defrag_ipv4(E) ip_tables(E) xt_conntrack(E) nf_conntrack(E) libcrc32c(E) ip6table_filter(E) ip6_tables(E) x_tables(E) snd_hda_codec_generic(E) snd_hda_intel(E) snd_hda_codec(E) snd_hda_core(E) joydev(E) snd_hwdep(E) snd_pcm(E) snd_timer(E) snd(E) 8139too(E) soundcore(E) i2c_piix4(E) virtio_balloon(E) crct10dif_pclmul(E) [ 328.476019] crc32_pclmul(E) ppdev(E) ghash_clmulni_intel(E) parport_pc(E) acpi_cpufreq(E) pcbc(E) button(E) parport(E) aesni_intel(E) aes_x86_64(E) serio_raw(E) pcspkr(E) crypto_simd(E) glue_helper(E) cryptd(E) nfsd(E) auth_rpcgss(E) nfs_acl(E) lockd(E) dm_mod(E) grace(E) sunrpc(E) ext4(E) crc16(E) jbd2(E) mbcache(E) hid_generic(E) usbhid(E) sr_mod(E) cdrom(E) ata_generic(E) virtio_blk(E) virtio_rng(E) virtio_console(E) ata_piix(E) qxl(E) drm_kms_helper(E) syscopyarea(E) uhci_hcd(E) ehci_pci(E) sysfillrect(E) sysimgblt(E) ahci(E) fb_sys_fops(E) ehci_hcd(E) libahci(E) crc32c_intel(E) ttm(E) virtio_pci(E) virtio_ring(E) 8139cp(E) virtio(E) usbcore(E) floppy(E) mii(E) drm(E) libata(E) sg(E) scsi_mod(E) autofs4(E) [ 328.476037] CPU: 6 PID: 313 Comm: kworker/u16:2 Tainted: G E 4.11.0-default #20 [ 328.476038] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS rel-1.8.1-0-g4adadbd-20161202_174313-build11a 04/01/2014 [ 328.476041] Workqueue: events_unbound async_run_entry_fn [ 328.476042] Call Trace: [ 328.476056] ? dump_stack+0x5c/0x85 [ 328.476058] ? __warn+0xc4/0xe0 [ 328.476060] ? pci_pm_poweroff+0xf0/0xf0 [ 328.476062] ? pci_irq_vector+0xb1/0xe0 [ 328.476064] ? vp_del_vqs+0xcb/0x120 [virtio_pci] [ 328.476066] ? remove_common+0x60/0x80 [virtio_rng] [ 328.476067] ? virtrng_freeze+0xa/0x10 [virtio_rng] [ 328.476068] ? virtio_pci_freeze+0x19/0x40 [virtio_pci] [ 328.476069] ? pci_pm_freeze+0x59/0xe0 [ 328.476070] ? dpm_run_callback+0x4d/0x170 [ 328.476071] ? __device_suspend+0x11f/0x3b0 [ 328.476072] ? pm_dev_dbg+0x70/0x70 [ 328.476072] ? async_suspend+0x1a/0x90 [ 328.476082] ? async_run_entry_fn+0x34/0x160 [ 328.476083] ? process_one_work+0x164/0x430 [ 328.476084] ? worker_thread+0x135/0x4d0 [ 328.476085] ? kthread+0xff/0x140 [ 328.476086] ? rescuer_thread+0x3c0/0x3c0 [ 328.476087] ? kthread_park+0x80/0x80 [ 328.476088] ? do_group_exit+0x39/0xa0 [ 328.476090] ? ret_from_fork+0x26/0x40 [ 328.476091] ---[ end trace a045c2118936902f ]---