Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753977AbdDDOn0 (ORCPT ); Tue, 4 Apr 2017 10:43:26 -0400 Received: from bastet.se.axis.com ([195.60.68.11]:39802 "EHLO bastet.se.axis.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753188AbdDDOnY (ORCPT ); Tue, 4 Apr 2017 10:43:24 -0400 From: Niklas Cassel Subject: Re: [PATCH v2] selftests: add a generic testsuite for ethernet device To: Corentin Labbe , , , , References: <20170404133247.28725-1-clabbe.montjoie@gmail.com> CC: , Message-ID: <8f363cf9-1696-bab9-ab54-a003541e1409@axis.com> Date: Tue, 4 Apr 2017 16:43:19 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Icedove/45.6.0 MIME-Version: 1.0 In-Reply-To: <20170404133247.28725-1-clabbe.montjoie@gmail.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.0.5.60] X-ClientProxiedBy: XBOX04.axis.com (10.0.5.18) To XBOX02.axis.com (10.0.5.16) X-TM-AS-GCONF: 00 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 801 Lines: 27 On 04/04/2017 03:32 PM, Corentin Labbe wrote: > This patch add a generic testsuite for testing ethernet network device driver. > > Signed-off-by: Corentin Labbe > --- > > Changes since v1: > - Test for starting master interface > - Changed printing format to "RESULT: $netdev: line" > - Use "ip link" to get device list > > tools/testing/selftests/net/Makefile | 2 +- > tools/testing/selftests/net/netdevice.sh | 200 +++++++++++++++++++++++++++++++ > 2 files changed, 201 insertions(+), 1 deletion(-) > create mode 100755 tools/testing/selftests/net/netdevice.sh > (snip) Good work! I suggest adding a test for setting MTU as well. It doesn't have to be added before merging, but it would be great if it could be added in the near future. Regards, Niklas