Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754246AbdDDOub (ORCPT ); Tue, 4 Apr 2017 10:50:31 -0400 Received: from mail-wm0-f65.google.com ([74.125.82.65]:34502 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753037AbdDDOuO (ORCPT ); Tue, 4 Apr 2017 10:50:14 -0400 Date: Tue, 4 Apr 2017 16:50:07 +0200 From: Corentin Labbe To: Niklas Cassel Cc: shuah@kernel.org, davem@davemloft.net, andrew@lunn.ch, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH v2] selftests: add a generic testsuite for ethernet device Message-ID: <20170404145007.GA8972@Red> References: <20170404133247.28725-1-clabbe.montjoie@gmail.com> <8f363cf9-1696-bab9-ab54-a003541e1409@axis.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8f363cf9-1696-bab9-ab54-a003541e1409@axis.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1052 Lines: 33 On Tue, Apr 04, 2017 at 04:43:19PM +0200, Niklas Cassel wrote: > On 04/04/2017 03:32 PM, Corentin Labbe wrote: > > This patch add a generic testsuite for testing ethernet network device driver. > > > > Signed-off-by: Corentin Labbe > > --- > > > > Changes since v1: > > - Test for starting master interface > > - Changed printing format to "RESULT: $netdev: line" > > - Use "ip link" to get device list > > > > tools/testing/selftests/net/Makefile | 2 +- > > tools/testing/selftests/net/netdevice.sh | 200 +++++++++++++++++++++++++++++++ > > 2 files changed, 201 insertions(+), 1 deletion(-) > > create mode 100755 tools/testing/selftests/net/netdevice.sh > > > (snip) > > Good work! > > I suggest adding a test for setting MTU as well. > It doesn't have to be added before merging, but it > would be great if it could be added in the near future. > > > Regards, > Niklas I already have it but prefer to add few test and add the rest one by one. But yes, I should add it as TODO like set ipaddr. Regards