Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754349AbdDDPHa (ORCPT ); Tue, 4 Apr 2017 11:07:30 -0400 Received: from resqmta-ch2-02v.sys.comcast.net ([69.252.207.34]:49652 "EHLO resqmta-ch2-02v.sys.comcast.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753226AbdDDPH3 (ORCPT ); Tue, 4 Apr 2017 11:07:29 -0400 Date: Tue, 4 Apr 2017 10:07:23 -0500 (CDT) From: Christoph Lameter X-X-Sender: cl@east.gentwo.org To: Michal Hocko cc: Kees Cook , Andrew Morton , Pekka Enberg , David Rientjes , Joonsoo Kim , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: Add additional consistency check In-Reply-To: <20170404113022.GC15490@dhcp22.suse.cz> Message-ID: References: <20170331164028.GA118828@beast> <20170404113022.GC15490@dhcp22.suse.cz> Content-Type: text/plain; charset=US-ASCII X-CMAE-Envelope: MS4wfBgGj6dxw4sVYuJUacPE/rMI9eaThSz+d3eh2rKBwaQAytfaQjSZgQ4uO7qiekErMDHpjEBBwnplGEf40fFrQQhZf1qqM7jLTsFaGbDPMMKyvPYkC9yN FlBlOuHMNonYFo9ei3Plu/Desb3b58iK1o4B6jHxF6ZBbzLk9dICeJ2bhD9EYGO6470jYTPiepZYW7IAp28Z8PZdzZlC4/LlYbsFNny9JNbHyasupnQDUzXx 1jIwHvoobrFkifyE50P2dEbL3YdJzrho/qJ2SIrIbLMac8xk1HdO/KIg7v0NFzxyZq/k8MM9bHDWijn3ctdJ30dEI6mPrpzIMnrYx+XgeYNXMUM9nXVXclFb q812rOQ5UZNIm9t//FYNh9ko5HOsk7Sf0ep+h4IwJ967KcsCGjQ= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 471 Lines: 12 On Tue, 4 Apr 2017, Michal Hocko wrote: > NAK without a proper changelog. Seriously, we do not blindly apply > changes from other projects without a deep understanding of all > consequences. Functionalitywise this is trivial. A page must be a slab page in order to be able to determine the slab cache of an object. Its definitely not ok if the page is not a slab page. The main issue that may exist here is the adding of overhead to a critical code path like kfree().