Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754680AbdDDRAS (ORCPT ); Tue, 4 Apr 2017 13:00:18 -0400 Received: from mail-qk0-f196.google.com ([209.85.220.196]:35088 "EHLO mail-qk0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751112AbdDDRAQ (ORCPT ); Tue, 4 Apr 2017 13:00:16 -0400 MIME-Version: 1.0 In-Reply-To: <20170323114727.g7huthlsuh7tplxk@dell> References: <1489745120-2918-1-git-send-email-ckeepax@opensource.wolfsonmicro.com> <1489745120-2918-2-git-send-email-ckeepax@opensource.wolfsonmicro.com> <20170323114727.g7huthlsuh7tplxk@dell> From: Andy Shevchenko Date: Tue, 4 Apr 2017 20:00:14 +0300 Message-ID: Subject: Re: [PATCH v5 2/3] gpio: wm831x: Add basic device tree support To: Lee Jones Cc: Charles Keepax , Rob Herring , Mark Rutland , Linus Walleij , Alexandre Courbot , devicetree , "linux-gpio@vger.kernel.org" , "linux-kernel@vger.kernel.org" , patches@opensource.wolfsonmicro.com Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 852 Lines: 32 On Thu, Mar 23, 2017 at 1:47 PM, Lee Jones wrote: > On Fri, 17 Mar 2017, Charles Keepax wrote: > >> Now the wm831x-core has basic DT support we can update this driver to >> allow use of the GPIOs within a device tree system. >> >> Signed-off-by: Charles Keepax >> Acked-by: Linus Walleij >> --- >> >> No changes since v4, still should go through Lee's tree. >> >> Thanks, >> Charles >> >> drivers/gpio/gpio-wm831x.c | 5 ++++- >> 1 file changed, 4 insertions(+), 1 deletion(-) > > Applied, thanks. >> +#ifdef CONFIG_OF_GPIO >> + wm831x_gpio->gpio_chip.of_node = wm831x->dev->of_node; >> +#endif Just a bit of off topic. If we can use struct fwnode_handle we might get rid of all those CONFIG_OF_GPIO in the drivers. -- With Best Regards, Andy Shevchenko