Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932220AbdDDRxY (ORCPT ); Tue, 4 Apr 2017 13:53:24 -0400 Received: from mga03.intel.com ([134.134.136.65]:36824 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752635AbdDDRxW (ORCPT ); Tue, 4 Apr 2017 13:53:22 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,275,1486454400"; d="scan'208";a="82923249" From: kan.liang@intel.com To: mingo@redhat.com, peterz@infradead.org, linux-kernel@vger.kernel.org Cc: eranian@google.com, ak@linux.intel.com, Kan Liang Subject: [PATCH] perf/x86: fix spurious NMI with PEBS Load Latency event Date: Tue, 4 Apr 2017 13:52:46 -0400 Message-Id: <1491328366-4089-1-git-send-email-kan.liang@intel.com> X-Mailer: git-send-email 2.4.3 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1924 Lines: 49 From: Kan Liang Spurious NMIs will be observed when applying the following command. while true ; do sudo perf record -b -a -e "cpu/umask=0x01,event=0xcd,ldlat=0x80/pp,cpu/umask=0x03,event=0x0/, cpu/umask=0x02,event=0x0/,cycles,branches,cache-misses, cache-references" -- sleep 10 ; done The issue was introduced by commit 8077eca079a2 ("perf/x86/pebs: Add workaround for broken OVFL status on HSW+") The previous patch clear the status's bits for the counters used for PEBS events, by masking the whole 64 bits pebs_enabled. However, only the lower 32 bits of both status and pebs_enabled are reserved for PEBS-able counters. For status, the first three bits of upper 32 bits are fixed counter overflow bit. For pebs_enabled, the first three bits of upper 32 bits are for PEBS Load Latency event. In the test case, the PEBS Load Latency event and fixed counter event could be overflowed at the same time. The fixed counter overflow bit will be cleared by mistake. Once it is cleared, the fixed counter overflow never be processed, which finally trigger spurious NMI. Correct the PEBS enabled mask by ignoring the non-PEBS bits. Fixes: 8077eca079a2 ("perf/x86/pebs: Add workaround for broken OVFL status on HSW+") Signed-off-by: Kan Liang --- arch/x86/events/intel/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/events/intel/core.c b/arch/x86/events/intel/core.c index 319da60..5b69787 100644 --- a/arch/x86/events/intel/core.c +++ b/arch/x86/events/intel/core.c @@ -2151,7 +2151,7 @@ static int intel_pmu_handle_irq(struct pt_regs *regs) * counters from the GLOBAL_STATUS mask and we always process PEBS * events via drain_pebs(). */ - status &= ~cpuc->pebs_enabled; + status &= ~(cpuc->pebs_enabled & ((1ULL << MAX_PEBS_EVENTS) - 1)); /* * PEBS overflow sets bit 62 in the global status register -- 2.4.3