Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755299AbdDDSax (ORCPT ); Tue, 4 Apr 2017 14:30:53 -0400 Received: from mail-yb0-f174.google.com ([209.85.213.174]:34618 "EHLO mail-yb0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753243AbdDDSau (ORCPT ); Tue, 4 Apr 2017 14:30:50 -0400 Date: Tue, 4 Apr 2017 14:30:47 -0400 From: Sean Paul To: John Keeping Cc: Sean Paul , Rob Herring , Brian Norris , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, Chris Zhong , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] dt-bindings: display: rk3288-mipi-dsi: add reset property Message-ID: <20170404183047.s7flyjv6vfhzxzb6@art_vandelay> References: <20170224125506.21533-1-john@metanate.com> <20170224125506.21533-24-john@metanate.com> <20170302215643.GA49163@google.com> <20170303113945.3bd2cbd9.john@metanate.com> <20170312120659.hpiwnsto6hkxs5yh@rob-hp-laptop> <20170404141513.2bad3b1b.john@metanate.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170404141513.2bad3b1b.john@metanate.com> User-Agent: NeoMutt/20170306-97-7656f1-dirty (1.8.0) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1413 Lines: 44 On Tue, Apr 04, 2017 at 02:15:13PM +0100, John Keeping wrote: > Hi Sean, > > On Sun, 12 Mar 2017 07:06:59 -0500, Rob Herring wrote: > > > On Fri, Mar 03, 2017 at 11:39:45AM +0000, John Keeping wrote: > > > This reset is required in order to fully reset the internal state of the > > > MIPI controller. > > > > > > Signed-off-by: John Keeping > > > --- > > > On Thu, 2 Mar 2017 13:56:46 -0800, Brian Norris wrote: > > > > On Fri, Feb 24, 2017 at 12:55:06PM +0000, John Keeping wrote: > > > > > + /* > > > > > + * Note that the reset was not defined in the initial device tree, so > > > > > + * we have to be prepared for it not being found. > > > > > + */ > > > > > + apb_rst = devm_reset_control_get(dev, "apb"); > > > > > > > > Did this reset ever get documented in the device tree bindings? I > > > > couldn't find it. Perhaps a follow-up patch is in order? > > > > > > Here's a patch to do that. > > > > > > .../devicetree/bindings/display/rockchip/dw_mipi_dsi_rockchip.txt | 7 +++++++ > > > 1 file changed, 7 insertions(+) > > > > Acked-by: Rob Herring > > I don't see this patch in linux-next, so I guess it has fallen through > the cracks somewhere. Since we have Rob's ack, can you pick this via > drm-misc? > Yeah, sorry about that. Applied to misc-next Sean > > Regards, > John -- Sean Paul, Software Engineer, Google / Chromium OS