Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932421AbdDDToa (ORCPT ); Tue, 4 Apr 2017 15:44:30 -0400 Received: from mail-yb0-f182.google.com ([209.85.213.182]:34644 "EHLO mail-yb0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753363AbdDDTo3 (ORCPT ); Tue, 4 Apr 2017 15:44:29 -0400 Date: Tue, 4 Apr 2017 15:44:26 -0400 From: Sean Paul To: Jeffy Chen Cc: linux-kernel@vger.kernel.org, briannorris@chromium.org, dianders@chromium.org, tfiga@chromium.org, seanpaul@chromium.org, zyw@rock-chips.com, mark.yao@rock-chips.com, Heiko Stuebner , dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, David Airlie , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 6/9] drm/rockchip: Reoder unload sequence Message-ID: <20170404194426.e7pxf4kj5lbkvp6s@art_vandelay> References: <1491046529-4310-1-git-send-email-jeffy.chen@rock-chips.com> <1491046529-4310-7-git-send-email-jeffy.chen@rock-chips.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1491046529-4310-7-git-send-email-jeffy.chen@rock-chips.com> User-Agent: NeoMutt/20170306-97-7656f1-dirty (1.8.0) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1442 Lines: 46 On Sat, Apr 01, 2017 at 07:35:26PM +0800, Jeffy Chen wrote: > We should not cleanup iommu before cleanup other resources. > > Reorder unload sequence, follow exynos drm. This doesn't match the cleanup sequence in rockchip_drm_bind. Also make sure that you're unwinding the setup sequence when you cleanup (ie: take a close look at how you set things up and reverse it for cleanup). Sean > > Signed-off-by: Jeffy Chen > --- > > Changes in v2: None > > drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_drv.c b/drivers/gpu/drm/rockchip/rockchip_drm_drv.c > index b360e62..a5d83cb 100644 > --- a/drivers/gpu/drm/rockchip/rockchip_drm_drv.c > +++ b/drivers/gpu/drm/rockchip/rockchip_drm_drv.c > @@ -244,11 +244,13 @@ static void rockchip_drm_unbind(struct device *dev) > struct drm_device *drm_dev = dev_get_drvdata(dev); > > rockchip_drm_fbdev_fini(drm_dev); > - drm_vblank_cleanup(drm_dev); > drm_kms_helper_poll_fini(drm_dev); > + > + drm_vblank_cleanup(drm_dev); > component_unbind_all(dev, drm_dev); > - rockchip_iommu_cleanup(drm_dev); > drm_mode_config_cleanup(drm_dev); > + rockchip_iommu_cleanup(drm_dev); > + > drm_dev->dev_private = NULL; > drm_dev_unregister(drm_dev); > drm_dev_unref(drm_dev); > -- > 2.1.4 > -- Sean Paul, Software Engineer, Google / Chromium OS