Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753764AbdDDUw6 (ORCPT ); Tue, 4 Apr 2017 16:52:58 -0400 Received: from zeniv.linux.org.uk ([195.92.253.2]:47514 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752419AbdDDUw4 (ORCPT ); Tue, 4 Apr 2017 16:52:56 -0400 Date: Tue, 4 Apr 2017 21:52:38 +0100 From: Al Viro To: Max Filippov Cc: linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, Linus Torvalds , Richard Henderson , Russell King , Will Deacon , Haavard Skinnemoen , Vineet Gupta , Steven Miao , Jesper Nilsson , Mark Salter , Yoshinori Sato , Richard Kuo , Tony Luck , Geert Uytterhoeven , James Hogan , Michal Simek , David Howells , Ley Foon Tan , Jonas Bonn , Helge Deller , Martin Schwidefsky , Ralf Baechle , Benjamin Herrenschmidt , Chen Liqin , "David S. Miller" , Chris Metcalf , Richard Weinberger , Guan Xuetao , Thomas Gleixner , Chris Zankel Subject: Re: [RFC][CFT][PATCHSET v1] uaccess unification Message-ID: <20170404205238.GP29622@ZenIV.linux.org.uk> References: <20170329055706.GH29622@ZenIV.linux.org.uk> <20170404202629.GA31611@octofox.metropolis> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170404202629.GA31611@octofox.metropolis> User-Agent: Mutt/1.7.1 (2016-10-04) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1728 Lines: 47 On Tue, Apr 04, 2017 at 01:26:29PM -0700, Max Filippov wrote: > On Wed, Mar 29, 2017 at 06:57:06AM +0100, Al Viro wrote: > > I hope that infrastructure part is stable enough to put it into never-rebased > > state. Some of per-architecture branches might be even done right; however, > > most of them got no testing whatsoever, so any help with testing (as well > > as "Al, for fuck sake, dump that garbage of yours, here's the correct patch" > > from maintainers) would be very welcome. So would the review, of course. > > For the xtensa part: > Tested-by: Max Filippov > > I believe that the xtensa part needs the following correction: Applied. > ---8<--- > >From 4505d69c3514fb12405409a7943e45831d037960 Mon Sep 17 00:00:00 2001 > From: Max Filippov > Date: Tue, 4 Apr 2017 13:20:34 -0700 > Subject: [PATCH] xtensa: fix prefetch in the raw_copy_to_user > > 'from' is the input buffer, it should be prefetched with prefetch, not > prefetchw. > > Signed-off-by: Max Filippov > --- > arch/xtensa/include/asm/uaccess.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/xtensa/include/asm/uaccess.h b/arch/xtensa/include/asm/uaccess.h > index 8e93ed8..2e7bac0 100644 > --- a/arch/xtensa/include/asm/uaccess.h > +++ b/arch/xtensa/include/asm/uaccess.h > @@ -245,7 +245,7 @@ raw_copy_from_user(void *to, const void __user *from, unsigned long n) > static inline unsigned long > raw_copy_to_user(void __user *to, const void *from, unsigned long n) > { > - prefetchw(from); > + prefetch(from); > return __xtensa_copy_user((__force void *)to, from, n); > } > #define INLINE_COPY_FROM_USER > ---8<--- > > -- > Thanks. > -- Max