Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754825AbdDDWHG (ORCPT ); Tue, 4 Apr 2017 18:07:06 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:33872 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753352AbdDDWHE (ORCPT ); Tue, 4 Apr 2017 18:07:04 -0400 Date: Tue, 4 Apr 2017 15:07:03 -0700 From: Andrew Morton To: Johannes Weiner Cc: Rik van Riel , Mel Gorman , Michal Hocko , Vladimir Davydov , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@fb.com Subject: Re: [PATCH] mm: vmscan: fix IO/refault regression in cache workingset transition Message-Id: <20170404150703.742c49d73921df6369ed3dbd@linux-foundation.org> In-Reply-To: <20170404220052.27593-1-hannes@cmpxchg.org> References: <20170404220052.27593-1-hannes@cmpxchg.org> X-Mailer: Sylpheed 3.4.1 (GTK+ 2.24.23; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1117 Lines: 22 On Tue, 4 Apr 2017 18:00:52 -0400 Johannes Weiner wrote: > Since 59dc76b0d4df ("mm: vmscan: reduce size of inactive file list") > we noticed bigger IO spikes during changes in cache access patterns. > > The patch in question shrunk the inactive list size to leave more room > for the current workingset in the presence of streaming IO. However, > workingset transitions that previously happened on the inactive list > are now pushed out of memory and incur more refaults to complete. > > This patch disables active list protection when refaults are being > observed. This accelerates workingset transitions, and allows more of > the new set to establish itself from memory, without eating into the > ability to protect the established workingset during stable periods. > > Fixes: 59dc76b0d4df ("mm: vmscan: reduce size of inactive file list") > Signed-off-by: Johannes Weiner > Cc: # 4.7+ That's a pretty large patch and the problem has been there for a year. I'm not sure that it's 4.11 material, let alone -stable. Care to explain further?