Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752231AbdDECzK (ORCPT ); Tue, 4 Apr 2017 22:55:10 -0400 Received: from mout.gmx.net ([212.227.17.21]:55439 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751854AbdDECzI (ORCPT ); Tue, 4 Apr 2017 22:55:08 -0400 Message-ID: <1491360898.4536.63.camel@gmx.de> Subject: Re: Random guest crashes since 5c34d002dcc7 ("virtio_pci: use shared interrupts for virtqueues") From: Mike Galbraith To: "Michael S. Tsirkin" Cc: Christoph Hellwig , Thorsten Leemhuis , virtio-dev@lists.oasis-open.org, Linux Kernel Mailing List , rjones@redhat.com Date: Wed, 05 Apr 2017 04:54:58 +0200 In-Reply-To: <20170405003005-mutt-send-email-mst@kernel.org> References: <1491242192.5638.111.camel@gmx.de> <20170403210931-mutt-send-email-mst@kernel.org> <1491278572.5198.28.camel@gmx.de> <20170404163725-mutt-send-email-mst@kernel.org> <1491315482.5239.11.camel@gmx.de> <20170404182904-mutt-send-email-mst@kernel.org> <1491327646.4253.2.camel@gmx.de> <1491328476.4253.10.camel@gmx.de> <20170404205921-mutt-send-email-mst@kernel.org> <1491331115.4253.41.camel@gmx.de> <20170405003005-mutt-send-email-mst@kernel.org> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.16.5 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:vFW15s1Q95EU2jVVG2BABWG/fnjLzKSuqLtAYoRBRwcFo4N/b+/ 7jdkwxVAmrXR/RqZvfM9tVLttl8XXEOBrtf9sZN6oW2+EJ4NovrOTlHjzo3rT/1LalgQdLI EKKGEsJ/y+cgG/4e9Gt23cZu7xJnM1OBVU4u4Csb7ZoNRaw+Wx84z84DXIEC8bI0b64Kirh F1PjqIX/yMzDdD4yFZtUw== X-UI-Out-Filterresults: notjunk:1;V01:K0:hTYjU+XOKKw=:lduFDV+SUOHvDJAhQAd93l RcuPbcj4XOPqACkjrcDQGrVf3G79jFk3mKwn0GCyt6YikrA7wMdNa5X+hxIU6OjcTEFbYcTcd U+wRMHISmeMLN2yxfEAdlTMbEMNQLIVAesnpmWax+DKQ9KeXV+EjEOTYbD9HaFRBFm43Vp58P 4yxUZS0GlwAQn66CAUWF2bTrXFTh3NV7tuxN2QE6QwZ3zcypuTnYsqFWv/yYzb8hrLnSa0/Om oO9aDFHjy1cSJuWxkqX9gD1ioHIhsT/CC8KyCAHiH1uuCYA3QqEKS6cw8oWGU8/oaXSgSFmt6 +f+X7Vt/ljQ2G7Ba4vfpKnkIbltrZjdZAgWt6P1Rrg+O+6ZmbjHObycBfN+qFdLb6aN4fS0r2 57HE2KNPNVl1XBOUeLU5Lf6ZG51324rVLfb08nhYAaNG+Gzp3PmEntRrZdJPGHD0B4CR83NXL eWOE6LdJht9EfwU9mU4IKX+6DLJ+dY8UZMwEtely/46aiS859jbN9mcbBspaTAHaE5bF08jYf vYMQMW3jaN0IkRvvVXkQ6Ng2CndeiZWy9VbRy9DUV/mW3zeTj0iuZdtJNaZNaZSinoD1SNqrW LEAPGnZMAm6ArqnHgAEcWkv4K/U3sCdr9vx2WFp7GFVv2/yFnkw6aX51ZTHnl8YXJxP1QVxYP Pt9gn/Dda0u/O/IYX55W5UjfcrvPOfHKgcq8OvyGg29Oz05yYCpvvDokJBz3F8N/nyIEUEX/a DQShKmb4clQylJ7cu5LyCu4IUPysCxS36GB7qy9KdzyaKL/MovFXPct/R2TFj3xCIX0H9np3a ib6dprx Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1540 Lines: 38 On Wed, 2017-04-05 at 00:31 +0300, Michael S. Tsirkin wrote: > On Tue, Apr 04, 2017 at 08:38:35PM +0200, Mike Galbraith wrote: > > On Tue, 2017-04-04 at 21:00 +0300, Michael S. Tsirkin wrote: > > > > > And just making double sure, the 1st version that has the issue > > > is 5c34d002dcc7, isn't it? I'm asking because subject says so > > > but then goes on to list subject from another commit. > > > This one is: > > > > virtio_pci: remove struct virtio_pci_vq_info > > > > When the hibernation related warnings started I don't know, I > > wasn't > > targeting that, those fell out of subsequent testing. > > I started out > > hunting console breakage point w. threaded irqs, which is > > 5c34d002dcc7. > > OK but 5c34d002dcc7 isn't "virtio_pci: use shared > interrupts for virtqueues". Heh, wrong sha.. $subject does however correctly identify in quotes the origin of the threaded irq woes. > I'm confused at this point. I would appreciate the summary of > which versions were tested and what did you see. Testing > a revert might also help. I already tested full revert. I went looking for what busted kvm for RT kernels, extracted the virtio series and quilt bisected that to use shared interrupts. I was going to just use my little turn off multiport hacklet to put spinning kworker on the back burner until the dust settled, but noticed that there was more going on, and none of it is RT specific (thus freeing up a back burner). >From there, it's all test what you/Christoph post, as you post it, in virgin source. -Mike