Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752723AbdDED1W (ORCPT ); Tue, 4 Apr 2017 23:27:22 -0400 Received: from mail.kernel.org ([198.145.29.136]:40180 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751885AbdDED1U (ORCPT ); Tue, 4 Apr 2017 23:27:20 -0400 Date: Tue, 4 Apr 2017 23:27:15 -0400 From: Steven Rostedt To: Sergey Senozhatsky Cc: Calvin Owens , Petr Mladek , Greg Kroah-Hartman , Jiri Slaby , Andrew Morton , Manuel =?UTF-8?B?U2Now7ZsbGlu?= =?UTF-8?B?Zw==?= , Hans de Goede , Paul Burton , linux-kernel@vger.kernel.org, kernel-team@fb.com, Sergey Senozhatsky Subject: Re: [RFC][PATCH 1/2] printk: Introduce per-console filtering of messages by loglevel Message-ID: <20170404232715.4633acc1@gandalf.local.home> In-Reply-To: <20170405021628.GC11669@jagdpanzerIV.localdomain> References: <20170405020800.GB11669@jagdpanzerIV.localdomain> <20170405021628.GC11669@jagdpanzerIV.localdomain> X-Mailer: Claws Mail 3.14.0 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 585 Lines: 21 On Wed, 5 Apr 2017 11:16:28 +0900 Sergey Senozhatsky wrote: > one more thing. > > this per-console filtering ignores... the "ignore_loglevel" param. > > early_param("ignore_loglevel", ignore_loglevel_setup); > module_param(ignore_loglevel, bool, S_IRUGO | S_IWUSR); > MODULE_PARM_DESC(ignore_loglevel, > "ignore loglevel setting (prints all kernel messages to the console)"); > > > my preference would be preserve "ignore_loglevel" behaviour. if > we are forced to 'ignore all loglevel filtering' then we should > do so. Agreed. -- Steve