Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752781AbdDEDa5 (ORCPT ); Tue, 4 Apr 2017 23:30:57 -0400 Received: from mail.kernel.org ([198.145.29.136]:40532 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751692AbdDEDaz (ORCPT ); Tue, 4 Apr 2017 23:30:55 -0400 Date: Tue, 4 Apr 2017 23:30:50 -0400 From: Steven Rostedt To: Calvin Owens Cc: Petr Mladek , Sergey Senozhatsky , Greg Kroah-Hartman , Jiri Slaby , Andrew Morton , Manuel =?UTF-8?B?U2Now7ZsbGluZw==?= , Hans de Goede , Paul Burton , , Subject: Re: [RFC][PATCH 2/2] printk: Add /sys/consoles/${con}/ and maxlevel attribute Message-ID: <20170404233050.3afba596@gandalf.local.home> In-Reply-To: <8d144e1ec0c18761c4a6e14353e49e81a81bc924.1491345440.git.calvinowens@fb.com> References: <8d144e1ec0c18761c4a6e14353e49e81a81bc924.1491345440.git.calvinowens@fb.com> X-Mailer: Claws Mail 3.14.0 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 674 Lines: 18 On Tue, 4 Apr 2017 16:03:20 -0700 Calvin Owens wrote: > This does the simplest possible thing: add a directory at the root of > sysfs that allows setting the "maxlevel" parameter for each console. > > We can let kobject destruction race with console removal: if it does, > maxlevel_{show,store}() will safely fail with -ENODEV. This is a little > weird, but avoids embedding the kobject and therefore needing to totally > refactor the way we handle console struct lifetime. Can you also add a patch that allows this to be set on the kernel command line, when the consoles are defined. -- Steve > > Signed-off-by: Calvin Owens