Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932319AbdDEIfE (ORCPT ); Wed, 5 Apr 2017 04:35:04 -0400 Received: from fllnx210.ext.ti.com ([198.47.19.17]:49386 "EHLO fllnx210.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932172AbdDEIfB (ORCPT ); Wed, 5 Apr 2017 04:35:01 -0400 Subject: Re: [PATCH v5 14/24] dt-bindings: mfd: syscon: Add documentation for #syscon-cells property To: Rob Herring References: <20170327094520.3129-1-kishon@ti.com> <20170327094520.3129-15-kishon@ti.com> <20170331185852.mxa4gvjxbuxl65dq@rob-hp-laptop> <20170331190627.nucviejokdklgtk7@rob-hp-laptop> CC: Bjorn Helgaas , Joao Pinto , , , , , , , , From: Kishon Vijay Abraham I Message-ID: <19ba5ea6-b12b-5b0f-dbbe-6bdba03120ac@ti.com> Date: Wed, 5 Apr 2017 13:55:36 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <20170331190627.nucviejokdklgtk7@rob-hp-laptop> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 904 Lines: 25 Hi Rob, On Saturday 01 April 2017 12:36 AM, Rob Herring wrote: > On Fri, Mar 31, 2017 at 01:58:52PM -0500, Rob Herring wrote: >> On Mon, Mar 27, 2017 at 03:15:10PM +0530, Kishon Vijay Abraham I wrote: >>> Add documentation for the optional #syscon-cells property to determine >>> the number of cells that should be given in the phandle while >>> referencing the syscon-node. >>> >>> Suggested-by: Rob Herring >> >> I did? When? >> >> I'm not remembering why we need this. Generally, phandles to a syscon >> are for a single defined purpose. When do we need a list of them? > > Ah, I remember now the context. I suggested using standard parsing > function rather than open coding. I wasn't suggesting changing the > binding. Instead of of_parse_phandle_with_args, can't > of_parse_phandle_with_fixed_args work? yes, it can be used. Will change it my next revision. Thanks Kishon