Message-ID: <1491381342.27353.76.camel@perches.com>
Subject: Re: [PATCH v1] checkpatch: test missing initial blank line in block
 comment
From: Joe Perches <joe@perches.com>
To: Hugues FRUCHET <hugues.fruchet@st.com>,
        Andy Whitcroft <apw@canonical.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Date: Wed, 05 Apr 2017 01:35:42 -0700
In-Reply-To: <5518d438-7c73-2ba0-de77-0650742895e6@st.com>
References: <1491206895-24332-1-git-send-email-hugues.fruchet@st.com>
         <1491206895-24332-2-git-send-email-hugues.fruchet@st.com>
         <1491246400.27353.59.camel@perches.com>
         <5518d438-7c73-2ba0-de77-0650742895e6@st.com>
Content-Type: text/plain; charset="ISO-8859-1"
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1333
Lines: 38

On Wed, 2017-04-05 at 08:23 +0000, Hugues FRUCHET wrote:
> Hi Joe, thanks for reviewing,

Hello Hugues

> I have run the command you advice on the entire kernel code, modifying 
> the script to only match the newly introduced check case.
> There was 14389 hits, quite huge, so I cannot 100% certify that there 
> are no false positives, but I have checked the output carefully and 
> found 2 limit cases:
> 
> 1) space character placed just after "/*"
> WARNING: Block comments starts with an empty /*
> #330: FILE: arch/alpha/kernel/core_irongate.c:330:
> +	/*
> +	 * Check for within the AGP aperture...
> => 146 hits (grep -c -n -E "\/\* $" /tmp/check.txt)
> 
> 2) // style comment followed by pointer dereference
> WARNING: Block comments starts with an empty /*
> #426: FILE: drivers/media/dvb-core/dvb_ca_en50221.c:426:
> +	// success
> +	*tupleType = _tupleType;
> => 4 hits
> 
> Anyway this reveal comment style related issues, so I would say that we 
> can keep script as it is, what do you think about ?

Glancing at the output, there is also the comment
in a multiline macro case:

WARNING: Block comments starts with an empty /*
#354: FILE: arch/mips/include/asm/processor.h:354:
+	/*							\
+	?* Other stuff associated with the process		\

Dunno how common that is, but maybe the test
should be changed to avoid those.