Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S933164AbdDEKDF (ORCPT <rfc822;w@1wt.eu>);
        Wed, 5 Apr 2017 06:03:05 -0400
Received: from mail-it0-f50.google.com ([209.85.214.50]:36293 "EHLO
        mail-it0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S932671AbdDEKDA (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 5 Apr 2017 06:03:00 -0400
MIME-Version: 1.0
In-Reply-To: <1491324314-27067-2-git-send-email-daniel.baluta@nxp.com>
References: <1491324314-27067-1-git-send-email-daniel.baluta@nxp.com> <1491324314-27067-2-git-send-email-daniel.baluta@nxp.com>
From: Daniel Baluta <daniel.baluta@gmail.com>
Date: Wed, 5 Apr 2017 13:02:59 +0300
Message-ID: <CAEnQRZAFPZYHNwmsaJ_4q1S-EaathwtEp=5fCS9Huu6qoZb3Hg@mail.gmail.com>
Subject: Re: [alsa-devel] [PATCH 1/2] ASoC: codec: wm9860: Refactor PLL out
 freq search
To: Daniel Baluta <daniel.baluta@nxp.com>
Cc: alsa-devel@alsa-project.org, Liam Girdwood <lgirdwood@gmail.com>,
        shengjiu.wang@nxp.com, patches@opensource.wolfsonmicro.com,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Takashi Iwai <tiwai@suse.com>, Mark Brown <broonie@kernel.org>,
        viorel.suman@nxp.com, mihai.serban@nxp.com,
        Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1157
Lines: 28

On Tue, Apr 4, 2017 at 7:45 PM, Daniel Baluta <daniel.baluta@nxp.com> wrote:
> Add a separate function for deriving (sysclk, lrclk, bclk)
> when the clock is auto or pll.
>
> Signed-off-by: Daniel Baluta <daniel.baluta@nxp.com>

Just noticed this warnings:

sound/soc/codecs/wm8960.c:743:3: warning: 'best_freq_out' may be used
uninitialized in this function [-Wmaybe-uninitialized]
   wm8960_set_pll(codec, freq_in, best_freq_out);
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
sound/soc/codecs/wm8960.c:703:21: note: 'best_freq_out' was declared here
  int diff, closest, best_freq_out;
                     ^~~~~~~~~~~~~
sound/soc/codecs/wm8960.c:806:46: warning: 'j' may be used
uninitialized in this function [-Wmaybe-uninitialized]
  snd_soc_update_bits(codec, WM8960_CLOCK1, 0x7 << 6, j << 6);
                                            ~~^~~~
sound/soc/codecs/wm8960.c:802:44: warning: 'i' may be used
uninitialized in this function [-Wmaybe-uninitialized]
  snd_soc_update_bits(codec, WM8960_CLOCK1, 3 << 1, i << 1);


There is no way I can end up with these variable uninitialized. Will
look more close and resend.

Thanks Charles for review.