Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933216AbdDEKVu (ORCPT ); Wed, 5 Apr 2017 06:21:50 -0400 Received: from regular1.263xmail.com ([211.150.99.140]:33284 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932079AbdDEKVO (ORCPT ); Wed, 5 Apr 2017 06:21:14 -0400 X-263anti-spam: KSV:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-RL-SENDER: jeffy.chen@rock-chips.com X-FST-TO: seanpaul@chromium.org X-SENDER-IP: 103.29.142.67 X-LOGIN-NAME: jeffy.chen@rock-chips.com X-UNIQUE-TAG: <0a562058f796da0b8e7a856d3ba3242e> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Message-ID: <58E4C4F2.7090306@rock-chips.com> Date: Wed, 05 Apr 2017 18:20:34 +0800 From: jeffy User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:19.0) Gecko/20130126 Thunderbird/19.0 MIME-Version: 1.0 To: Sean Paul CC: linux-kernel@vger.kernel.org, briannorris@chromium.org, dianders@chromium.org, tfiga@chromium.org, zyw@rock-chips.com, mark.yao@rock-chips.com, Heiko Stuebner , dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, David Airlie , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 6/9] drm/rockchip: Reoder unload sequence References: <1491046529-4310-1-git-send-email-jeffy.chen@rock-chips.com> <1491046529-4310-7-git-send-email-jeffy.chen@rock-chips.com> <20170404194426.e7pxf4kj5lbkvp6s@art_vandelay> In-Reply-To: <20170404194426.e7pxf4kj5lbkvp6s@art_vandelay> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1535 Lines: 49 Hi Sean, On 04/05/2017 03:44 AM, Sean Paul wrote: > On Sat, Apr 01, 2017 at 07:35:26PM +0800, Jeffy Chen wrote: >> We should not cleanup iommu before cleanup other resources. >> >> Reorder unload sequence, follow exynos drm. > > This doesn't match the cleanup sequence in rockchip_drm_bind. Also make sure > that you're unwinding the setup sequence when you cleanup (ie: take a close look > at how you set things up and reverse it for cleanup). ok, will reoder the bind sequence too, thanx. > > Sean > >> >> Signed-off-by: Jeffy Chen >> --- >> >> Changes in v2: None >> >> drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 6 ++++-- >> 1 file changed, 4 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_drv.c b/drivers/gpu/drm/rockchip/rockchip_drm_drv.c >> index b360e62..a5d83cb 100644 >> --- a/drivers/gpu/drm/rockchip/rockchip_drm_drv.c >> +++ b/drivers/gpu/drm/rockchip/rockchip_drm_drv.c >> @@ -244,11 +244,13 @@ static void rockchip_drm_unbind(struct device *dev) >> struct drm_device *drm_dev = dev_get_drvdata(dev); >> >> rockchip_drm_fbdev_fini(drm_dev); >> - drm_vblank_cleanup(drm_dev); >> drm_kms_helper_poll_fini(drm_dev); >> + >> + drm_vblank_cleanup(drm_dev); >> component_unbind_all(dev, drm_dev); >> - rockchip_iommu_cleanup(drm_dev); >> drm_mode_config_cleanup(drm_dev); >> + rockchip_iommu_cleanup(drm_dev); >> + >> drm_dev->dev_private = NULL; >> drm_dev_unregister(drm_dev); >> drm_dev_unref(drm_dev); >> -- >> 2.1.4 >> >