Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932649AbdDEK0P (ORCPT ); Wed, 5 Apr 2017 06:26:15 -0400 Received: from regular1.263xmail.com ([211.150.99.130]:51849 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932269AbdDEK0N (ORCPT ); Wed, 5 Apr 2017 06:26:13 -0400 X-263anti-spam: KSV:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-RL-SENDER: jeffy.chen@rock-chips.com X-FST-TO: daniel@ffwll.ch X-SENDER-IP: 103.29.142.67 X-LOGIN-NAME: jeffy.chen@rock-chips.com X-UNIQUE-TAG: <6691db6a82b8e369cc37122a89ab1a9a> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Message-ID: <58E4C602.4090302@rock-chips.com> Date: Wed, 05 Apr 2017 18:25:06 +0800 From: jeffy User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:19.0) Gecko/20130126 Thunderbird/19.0 MIME-Version: 1.0 To: Daniel Vetter CC: Linux Kernel Mailing List , Brian Norris , Douglas Anderson , dri-devel , Tomasz Figa , "open list:ARM/Rockchip SoC..." , Chris Zhong , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH v2 7/9] drm/rockchip: Force disable all crtc when unload References: <1491046529-4310-1-git-send-email-jeffy.chen@rock-chips.com> <1491046529-4310-8-git-send-email-jeffy.chen@rock-chips.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 818 Lines: 20 Hi Daniel, On 04/03/2017 03:58 PM, Daniel Vetter wrote: > On Sat, Apr 1, 2017 at 1:35 PM, Jeffy Chen wrote: >> diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_drv.c b/drivers/gpu/drm/rockchip/rockchip_drm_drv.c >> index a5d83cb..5dbf011 100644 >> --- a/drivers/gpu/drm/rockchip/rockchip_drm_drv.c >> +++ b/drivers/gpu/drm/rockchip/rockchip_drm_drv.c >> @@ -246,6 +246,7 @@ static void rockchip_drm_unbind(struct device *dev) >> rockchip_drm_fbdev_fini(drm_dev); >> drm_kms_helper_poll_fini(drm_dev); >> >> + drm_crtc_force_disable_all(drm_dev); > > This will result in a WARN_ON in latest drm-next because rockchip is > atomic, and this helper is for legacy kms drivers. You want to use > drm_atomic_helper_shutdown here. > -Daniel > oops, thanx for the notice.