Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933566AbdDEKuY (ORCPT ); Wed, 5 Apr 2017 06:50:24 -0400 Received: from Galois.linutronix.de ([146.0.238.70]:59954 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933219AbdDEKuW (ORCPT ); Wed, 5 Apr 2017 06:50:22 -0400 Date: Wed, 5 Apr 2017 12:50:19 +0200 (CEST) From: Thomas Gleixner To: Dou Liyang cc: x86@kernel.org, linux-kernel@vger.kernel.org, mingo@kernel.org, ebiederm@xmission.com, bhe@redhat.com, hpa@zytor.com, izumi.taku@jp.fujitsu.com Subject: Re: [RFC PATCH 1/6] x86/apic: Replace init_bsp_APIC() with apic_virture_wire_mode_setup() In-Reply-To: Message-ID: References: <1490799333-18242-1-git-send-email-douly.fnst@cn.fujitsu.com> <1490799333-18242-2-git-send-email-douly.fnst@cn.fujitsu.com> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 925 Lines: 33 On Wed, 5 Apr 2017, Thomas Gleixner wrote: > On Wed, 29 Mar 2017, Dou Liyang wrote: > > > The init_bsp_APIC() setups the virtual wire mode through the local > > APIC. > > > > The function name is unsuitable which might imply that the BSP's > > APIC will be initialized here, actually, where it will be done is > > almost at the end of start_kernel(). And the CONFIG X86_64 is also > > imply the X86_LOCAL_APIC is y. > > Correct, but X86_32 can have X86_LOCAL_APIC=n. And by removing the ifdefs > you break that. Oops. Sorry, the function is replaced by an empty stub for the APIC=n case. So that's correct. > > /* > > - * An initial setup of the virtual wire mode. > > + * Setup the through-local-APIC virtual wire mode. > > */ > > -void __init init_bsp_APIC(void) > > +void apic_virture_wire_mode_setup(void) > > s/virture/virtual/ ? > > Why is this function not longer marked __init ? > > Thanks, > > tglx >