Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755216AbdDEMmt (ORCPT ); Wed, 5 Apr 2017 08:42:49 -0400 Received: from mail-dm3nam03on0072.outbound.protection.outlook.com ([104.47.41.72]:40548 "EHLO NAM03-DM3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753238AbdDEMmW (ORCPT ); Wed, 5 Apr 2017 08:42:22 -0400 From: "Mintz, Yuval" To: Colin King , "Elior, Ariel" , "netdev@vger.kernel.org" CC: "kernel-janitors@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH] qed: fix missing break in OOO_LB_TC case Thread-Topic: [PATCH] qed: fix missing break in OOO_LB_TC case Thread-Index: AQHSrgknaELcWTC+R0yzkALOdMdb86G2t8Jw Date: Wed, 5 Apr 2017 12:42:18 +0000 Message-ID: References: <20170405123544.18648-1-colin.king@canonical.com> In-Reply-To: <20170405123544.18648-1-colin.king@canonical.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: canonical.com; dkim=none (message not signed) header.d=none;canonical.com; dmarc=none action=none header.from=cavium.com; x-originating-ip: [31.168.140.228] x-microsoft-exchange-diagnostics: 1;BN3PR0701MB1331;7:o3aWZqYJt4e5gNS6hLbRfeLsBdgEcFxUG+VCKjEMbFEyP9s0YLvKkhUjLQnDGgYhvmoo4S2yiQa63xWATvAcXgIfOWA1bp0TxmElJN9m0m9yGa3E86utsnEdDV/h8To41yd/9guwUOPrZZy//CcbtrnSNCE4bq+mUnu5sQN7O4HLXmC8z/I3WZpugi8TjjZcOt/JVcoBXLBYZldjjmKMvo/iHR8tB22+jzciYZinyLrodLsFUuDMC4iY+oKLDTJTqAVp78l16Ef/CcEja/b0EemFBBDU5QBEzzyEr6fndPJxsw9XkwsrdnU9RvtqdE7dU84MYARgWUXr8baqEEhPQw== x-forefront-antispam-report: SFV:SKI;SCL:-1SFV:NSPM;SFS:(10009020)(6009001)(39840400002)(39410400002)(39850400002)(39400400002)(39450400003)(2501003)(38730400002)(25786009)(6246003)(3660700001)(122556002)(81166006)(189998001)(4326008)(3846002)(2950100002)(7696004)(6116002)(102836003)(6436002)(8936002)(76176999)(33656002)(54356999)(86362001)(2900100001)(3280700002)(8676002)(229853002)(74316002)(305945005)(7736002)(66066001)(55016002)(77096006)(53936002)(6506006)(9686003)(99286003)(54906002)(50986999);DIR:OUT;SFP:1101;SCL:1;SRVR:BN3PR0701MB1331;H:BL2PR07MB2306.namprd07.prod.outlook.com;FPR:;SPF:None;MLV:sfv;LANG:en; x-ms-office365-filtering-correlation-id: ea46a8bf-04d7-4cc3-875b-08d47c213272 x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(2017030254075)(201703131423075)(201703031133081)(201702281549075);SRVR:BN3PR0701MB1331; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(198206253151910); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040450)(601004)(2401047)(8121501046)(5005006)(93006095)(93001095)(10201501046)(3002001)(6041248)(201703131423075)(201702281528075)(201703061421075)(20161123564025)(20161123555025)(20161123562025)(20161123560025)(6072148);SRVR:BN3PR0701MB1331;BCL:0;PCL:0;RULEID:;SRVR:BN3PR0701MB1331; x-forefront-prvs: 0268246AE7 spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Apr 2017 12:42:18.5557 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR0701MB1331 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id v35CiglF003027 Content-Length: 413 Lines: 13 > There seems to be a missing break on the OOO_LB_TC case, pq_id is being > assigned and then re-assigned on the fall through default case and that > seems suspect. > > Detected by CoverityScan, CID#1424402 ("Missing break in switch") > > Fixes: b5a9ee7cf3be1 ("qed: Revise QM cofiguration") > > Signed-off-by: Colin Ian King Thanks! Acked-by: Yuval Mintz