Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932636AbdDEMpS (ORCPT ); Wed, 5 Apr 2017 08:45:18 -0400 Received: from mail-sn1nam02on0067.outbound.protection.outlook.com ([104.47.36.67]:19023 "EHLO NAM02-SN1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755413AbdDEMpL (ORCPT ); Wed, 5 Apr 2017 08:45:11 -0400 From: "Kershner, David A" To: Thomas Jespersen CC: "gregkh@linuxfoundation.org" , "Sell, Timothy C" , "Binder, David Anthony" , "Frisch, Jon" , "erik.arfvidson@unisys.com" , *S-Par-Maintainer , "devel@driverdev.osuosl.org" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH] unisys: visornic: Replace symbolic perms with octal Thread-Topic: [PATCH] unisys: visornic: Replace symbolic perms with octal Thread-Index: AQHSrXfOid8rZwT0bkaKjB1nLclwpqG2uGEg Date: Wed, 5 Apr 2017 12:45:02 +0000 Message-ID: References: <20170404191514.8434-1-laumann.thomas@gmail.com> In-Reply-To: <20170404191514.8434-1-laumann.thomas@gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: gmail.com; dkim=none (message not signed) header.d=none;gmail.com; dmarc=none action=none header.from=unisys.com; x-originating-ip: [108.36.162.151] x-microsoft-exchange-diagnostics: 1;CY4PR07MB3126;7:7Mq4/2U6VCAbjzg3EiDEZJ91ox13edUdP0JyfuP//65MZOgPXCGXEfk3Ftxt4YFDvRZMQ6Ouy0014XcSVFcUnmazWLuFNxZr2CfsGl5e4KMc327YBPJnrPyA/6FvboaXHn6AIsZHPf072XANVf79d9e+vbzbN3K238wLYb1Ytbr17ykp4kZGZDf5A/Lz09YvlwljWqMtE1ROspCxt+Gkf/SZqCttpHyZzNjgDPQj/YzTaR1ScGGuosxEGavFEbuPlWuU+vwZWiex64dBGL7ez8VV7TTBkycBSY5I8Oqi3r/qhe2J1/HeHSG2rswdBr3ZA0fniA0i4L0qZfQjc96/bg== x-ms-office365-filtering-correlation-id: d1a9cd01-0d6e-423d-cca4-08d47c21946f x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(2017030254075)(201703131423075)(201703031133081);SRVR:CY4PR07MB3126; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(9452136761055)(174360191007938)(788757137089); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040450)(601004)(2401047)(8121501046)(5005006)(10201501046)(93006095)(93001095)(3002001)(6041248)(201703131423075)(201702281528075)(201703061421075)(20161123564025)(20161123560025)(20161123555025)(20161123562025)(6072148);SRVR:CY4PR07MB3126;BCL:0;PCL:0;RULEID:;SRVR:CY4PR07MB3126; x-forefront-prvs: 0268246AE7 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(6009001)(39850400002)(39450400003)(39410400002)(39400400002)(39860400002)(39840400002)(13464003)(377454003)(76176999)(50986999)(54356999)(4326008)(6116002)(102836003)(3846002)(6506006)(189998001)(53936002)(6436002)(9686003)(99286003)(54906002)(55016002)(77096006)(7696004)(2950100002)(53546009)(25786009)(33656002)(229853002)(110136004)(39060400002)(6916009)(38730400002)(6246003)(8676002)(86362001)(81166006)(2900100001)(8936002)(5660300001)(66066001)(3280700002)(7736002)(2906002)(3660700001)(74316002)(122556002)(305945005);DIR:OUT;SFP:1101;SCL:1;SRVR:CY4PR07MB3126;H:CY4PR07MB3176.namprd07.prod.outlook.com;FPR:;SPF:None;MLV:ovrnspm;PTR:InfoNoRecords;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-OriginatorOrg: unisys.com X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Apr 2017 12:45:02.9850 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 8d894c2b-238f-490b-8dd1-d93898c5bf83 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR07MB3126 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v35Cl3BS003279 Content-Length: 1843 Lines: 52 > -----Original Message----- > From: Thomas Jespersen [mailto:laumann.thomas@gmail.com] > Sent: Tuesday, April 4, 2017 3:15 PM > To: Kershner, David A > Cc: gregkh@linuxfoundation.org; Sell, Timothy C > ; Binder, David Anthony > ; Frisch, Jon ; > erik.arfvidson@unisys.com; *S-Par-Maintainer > ; devel@driverdev.osuosl.org; linux- > kernel@vger.kernel.org > Subject: [PATCH] unisys: visornic: Replace symbolic perms with octal > Should the subject line say "staging: unisys: visornic" instead of just "unisys: visornic:"? Besides that, I'm fine with this patch and have tested it on s-Par. David Kershner > Replace symbolic permissions S_IRUSR and S_IWUSR for their octal > counterparts > > Signed-off-by: Thomas Jespersen > --- > drivers/staging/unisys/visornic/visornic_main.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/unisys/visornic/visornic_main.c > b/drivers/staging/unisys/visornic/visornic_main.c > index feece91..1008337 100644 > --- a/drivers/staging/unisys/visornic/visornic_main.c > +++ b/drivers/staging/unisys/visornic/visornic_main.c > @@ -2146,11 +2146,11 @@ static int visornic_init(void) > if (!visornic_debugfs_dir) > return err; > > - ret = debugfs_create_file("info", S_IRUSR, visornic_debugfs_dir, > NULL, > + ret = debugfs_create_file("info", 0400, visornic_debugfs_dir, NULL, > &debugfs_info_fops); > if (!ret) > goto cleanup_debugfs; > - ret = debugfs_create_file("enable_ints", S_IWUSR, > visornic_debugfs_dir, > + ret = debugfs_create_file("enable_ints", 0200, visornic_debugfs_dir, > NULL, &debugfs_enable_ints_fops); > if (!ret) > goto cleanup_debugfs; > -- > 2.10.2