Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932632AbdDENy2 (ORCPT ); Wed, 5 Apr 2017 09:54:28 -0400 Received: from mx0a-001ae601.pphosted.com ([67.231.149.25]:40967 "EHLO mx0b-001ae601.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754411AbdDENyL (ORCPT ); Wed, 5 Apr 2017 09:54:11 -0400 Authentication-Results: ppops.net; spf=none smtp.mailfrom=rf@opensource.wolfsonmicro.com Message-ID: <1491400437.4096.5.camel@rf-debian.wolfsonmicro.main> Subject: Re: [PATCH 07/16] regulator: madera-micsupp: Mic supply for Cirrus Logic Madera codecs From: Richard Fitzgerald To: Mark Brown CC: , , , , , , , , , , Date: Wed, 5 Apr 2017 14:53:57 +0100 In-Reply-To: <20170405134054.kz3j56vza4pqki75@sirena.org.uk> References: <1491386884-30689-1-git-send-email-rf@opensource.wolfsonmicro.com> <1491386884-30689-8-git-send-email-rf@opensource.wolfsonmicro.com> <20170405134054.kz3j56vza4pqki75@sirena.org.uk> Content-Type: text/plain; charset="us-ascii" X-Mailer: Evolution 3.4.4-3 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1702020001 definitions=main-1704050122 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 580 Lines: 13 On Wed, 2017-04-05 at 14:40 +0100, Mark Brown wrote: > On Wed, Apr 05, 2017 at 11:07:55AM +0100, Richard Fitzgerald wrote: > > The adds a driver for the microphone supply regulator on Cirrus Logic > > Madera class codecs. > > Again, this appears to have only data and minor code style changes > relative to the existing arizona driver - is there no opportunity for > code sharing here? I'll have a look at how it would work out. My thought was that these two regulator drivers are so small it wasn't worth creating an entanglement between arizona and madera for so little code.