Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933052AbdDEOZP convert rfc822-to-8bit (ORCPT ); Wed, 5 Apr 2017 10:25:15 -0400 Received: from mail.kernel.org ([198.145.29.136]:50828 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932359AbdDEOZD (ORCPT ); Wed, 5 Apr 2017 10:25:03 -0400 MIME-Version: 1.0 In-Reply-To: References: <20170324153321.4168-1-atull@kernel.org> <20170324153321.4168-2-atull@kernel.org> <20170330224429.yo42hgnr7nhm2ljv@rob-hp-laptop> From: Alan Tull Date: Wed, 5 Apr 2017 09:24:16 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 1/2] doc: Add bindings document for Xilinx LogiCore PR Decoupler To: Moritz Fischer Cc: Rob Herring , Greg Kroah-Hartman , Linux Kernel Mailing List , linux-fpga@vger.kernel.org, Moritz Fischer , Michal Simek , =?UTF-8?Q?S=C3=B6ren_Brinkmann?= , Devicetree List Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3749 Lines: 103 On Tue, Apr 4, 2017 at 6:36 PM, Moritz Fischer wrote: > On Thu, Mar 30, 2017 at 05:44:29PM -0500, Rob Herring wrote: >> On Fri, Mar 24, 2017 at 10:33:20AM -0500, Alan Tull wrote: >> > From: Moritz Fischer >> >> Please use "dt-bindings: fpga: ..." for the subject. >> >> >> > >> > This adds the binding documentation for the Xilinx LogiCORE PR >> > Decoupler soft core. >> > >> > Signed-off-by: Moritz Fischer >> > Signed-off-by: Michal Simek >> > Acked-by: Alan Tull >> >> I'm confused why you are sending these instead of Moritz? If it goes >> through you, then it should have your S-o-B too. Greg asked me to send patches to him. I should have started adding my signed-of-by at that point. > > Do you want me to resend this Alan (with Rob's suggestions)? I sent a set of patches to Greg on March 24. Looking back on that I realize that it didn't have Rob's ack yet (as well as having my ack where it should have been my signed-of-by). Yes, please resend this patchset with Rob's feedback. Thanks, ALan >> >> > Cc: Sören Brinkmann >> > Cc: linux-kernel@vger.kernel.org >> > Cc: devicetree@vger.kernel.org >> > --- >> > .../bindings/fpga/xilinx-pr-decoupler.txt | 35 ++++++++++++++++++++++ >> > 1 file changed, 35 insertions(+) >> > create mode 100644 Documentation/devicetree/bindings/fpga/xilinx-pr-decoupler.txt >> > >> > diff --git a/Documentation/devicetree/bindings/fpga/xilinx-pr-decoupler.txt b/Documentation/devicetree/bindings/fpga/xilinx-pr-decoupler.txt >> > new file mode 100644 >> > index 000000000000..2c527ac30398 >> > --- /dev/null >> > +++ b/Documentation/devicetree/bindings/fpga/xilinx-pr-decoupler.txt >> > @@ -0,0 +1,35 @@ >> > +Xilinx LogiCORE Partial Reconfig Decoupler Softcore >> > + >> > +The Xilinx LogiCORE Partial Reconfig Decoupler manages one or more >> > +decouplers / fpga bridges. >> > +The controller can decouple/disable the bridges which prevents signal >> > +changes from passing through the bridge. The controller can also >> > +couple / enable the bridges which allows traffic to pass through the >> > +bridge normally. >> > + >> > +The Driver supports only MMIO handling. A PR region can have multiple >> > +PR Decouplers which can be handled independently or chained via decouple/ >> > +decouple_status signals. >> > + >> > +Required properties: >> > +- compatible : Should contain "xlnx,pr-decoupler-1.00" or "xlnx,pr-decoupler" >> >> I'd drop xlnx,pr-decoupler, but in any case, it should not be OR rather >> "followed by". Plus the example has both. > > Michal wanted to have both, so I put both. Personally I don't care. I > think they have some downstream stuff that relied on it. > >> >> > +- regs : base address and size for decoupler module >> > +- clocks : input clock to IP >> > +- clock-names : should contain "aclk" >> > + >> > +Optional properties: >> > +- bridge-enable : 0 if driver should disable bridge at startup >> > + 1 if driver should enable bridge at startup >> > + Default is to leave bridge in current state. >> > + >> > +See Documentation/devicetree/bindings/fpga/fpga-region.txt for generic bindings. >> > + >> > +Example: >> > + fpga-bridge@100000450 { >> > + compatible = "xlnx,pr-decoupler-1.00", >> > + "xlnx-pr-decoupler"; >> > + regs = <0x10000045 0x10>; >> > + clocks = <&clkc 15>; >> > + clock-names = "aclk"; >> > + bridge-enable = <0>; >> > + }; >> > -- >> > 2.11.0 >> > >> > -- >> > To unsubscribe from this list: send the line "unsubscribe devicetree" in >> > the body of a message to majordomo@vger.kernel.org >> > More majordomo info at http://vger.kernel.org/majordomo-info.html > > Thanks, > Moritz