Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755434AbdDEOd0 (ORCPT ); Wed, 5 Apr 2017 10:33:26 -0400 Received: from mx1.redhat.com ([209.132.183.28]:60044 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754343AbdDEOdF (ORCPT ); Wed, 5 Apr 2017 10:33:05 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com BD916C01C70E Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=dhowells@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com BD916C01C70E Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: References: <148059537897.31612.9461043954611464597.stgit@warthog.procyon.org.uk> <148059559339.31612.16180464424786438715.stgit@warthog.procyon.org.uk> To: Finn Thain Cc: dhowells@redhat.com, linux-kernel@vger.kernel.org, Michael Schmitz , Achim Leubner , "James E.J. Bottomley" , linux-scsi@vger.kernel.org, "Martin K. Petersen" , gnomes@lxorguk.ukuu.org.uk, linux-security-module@vger.kernel.org, keyrings@vger.kernel.org, minyard@acm.org, "Juergen E. Fischer" , Dario Ballabio Subject: Re: [PATCH 27/39] Annotate hardware config module parameters in drivers/scsi/ MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <24494.1491402780.1@warthog.procyon.org.uk> Date: Wed, 05 Apr 2017 15:33:00 +0100 Message-ID: <24495.1491402780@warthog.procyon.org.uk> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Wed, 05 Apr 2017 14:33:05 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 488 Lines: 11 Finn Thain wrote: > I can see how base addresses and IO ports are relevant, but the irq > parameter changes below don't protect the kernel image AFAICT. What's the > rationale for those changes? I think it should be stated here. Easier grepping for one. But I'm also currently preventing the changing of any hardware parameters. If a driver refuses to share an irq, you could use it to deprive another driver of the ability to get an irq at all. David