Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932595AbdDEQgc (ORCPT ); Wed, 5 Apr 2017 12:36:32 -0400 Received: from merlin.infradead.org ([205.233.59.134]:53970 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754966AbdDEQf5 (ORCPT ); Wed, 5 Apr 2017 12:35:57 -0400 Subject: Re: [PATCH v5 19/23] drivers/fsi: Add GPIO based FSI master To: Christopher Bostic , robh+dt@kernel.org, mark.rutland@arm.com, linux@armlinux.org.uk, rostedt@goodmis.org, mingo@redhat.com, gregkh@linuxfoundation.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20170405020607.79939-1-cbostic@linux.vnet.ibm.com> <20170405020607.79939-20-cbostic@linux.vnet.ibm.com> Cc: joel@jms.id.au, linux-kernel@vger.kernel.org, andrew@aj.id.au, alistair@popple.id.au, benh@kernel.crashing.org, "Edward A . James" , Jeremy Kerr From: Randy Dunlap Message-ID: <5d173f9c-e01c-6093-16ab-d114857009b2@infradead.org> Date: Wed, 5 Apr 2017 09:35:40 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170405020607.79939-20-cbostic@linux.vnet.ibm.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1438 Lines: 47 On 04/04/17 19:06, Christopher Bostic wrote: > From: Chris Bostic > > Implement a FSI master using GPIO. Will generate FSI protocol for > read and write commands to particular addresses. Sends master command > and waits for and decodes a slave response. > > Includes changes from Edward A. James and Jeremy > Kerr . > > Signed-off-by: Edward A. James > Signed-off-by: Jeremy Kerr > Signed-off-by: Chris Bostic > Signed-off-by: Joel Stanley > --- > drivers/fsi/Kconfig | 11 + > drivers/fsi/Makefile | 1 + > drivers/fsi/fsi-master-gpio.c | 610 ++++++++++++++++++++++++++++++++++++++++++ > 3 files changed, 622 insertions(+) > create mode 100644 drivers/fsi/fsi-master-gpio.c > > diff --git a/drivers/fsi/Kconfig b/drivers/fsi/Kconfig > index 04c1a0e..9cf8345 100644 > --- a/drivers/fsi/Kconfig > +++ b/drivers/fsi/Kconfig > @@ -9,4 +9,15 @@ config FSI > ---help--- > FSI - the FRU Support Interface - is a simple bus for low-level > access to POWER-based hardware. > + > +if FSI > + > +config FSI_MASTER_GPIO > + tristate "GPIO-based FSI master" > + depends on FSI && GPIOLIB depends on FSI is redundant since "if FSI" does the same thing. > + ---help--- > + This option enables a FSI master driver using GPIO lines. > + > +endif > + -- ~Randy