Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756093AbdDEUPY (ORCPT ); Wed, 5 Apr 2017 16:15:24 -0400 Received: from mga07.intel.com ([134.134.136.100]:61088 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756008AbdDEUPI (ORCPT ); Wed, 5 Apr 2017 16:15:08 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.37,280,1488873600"; d="scan'208";a="83619992" Date: Wed, 5 Apr 2017 13:17:02 -0700 From: Fenghua Yu To: "Luck, Tony" Cc: Thomas Gleixner , Vikas Shivappa , vikas.shivappa@intel.com, x86@kernel.org, linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@kernel.org, peterz@infradead.org, ravi.v.shankar@intel.com, fenghua.yu@intel.com, h.peter.anvin@intel.com Subject: Re: [PATCH 1/3] x86/intel_rdt: Fix issue when mkdir uses a freed CLOSid Message-ID: <20170405201701.GA33377@linux.intel.com> References: <1491255857-17213-1-git-send-email-vikas.shivappa@linux.intel.com> <1491255857-17213-2-git-send-email-vikas.shivappa@linux.intel.com> <20170405180737.GA4850@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170405180737.GA4850@intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1011 Lines: 27 On Wed, Apr 05, 2017 at 11:07:37AM -0700, Luck, Tony wrote: > On Wed, Apr 05, 2017 at 05:20:24PM +0200, Thomas Gleixner wrote: > > That's just wrong. > > > > The proper behaviour for a new control group is, that at the time when it > > is created it copies the CBM values of the default group and not claiming > > access to ALL of the cache by default. > > I don't see that as any more helpful. When you make a new > control group it is because none of the existing groups > provides the QoS that you want. So the first thing the > user will do is write the schemata file with the values > they do want. > > So "all access", or "same as default group" are both the > same to the user ... not what they want. > > We do need to make sure that the schemata matches what is > in the registers. We need to make sure that changes to the > schemata file result in the MSRs being written where needed. FYI. This behavior and a fix patch were discussed before: http://lkml.org/lkml/2017/1/9/747 Thanks. -Fenghua