Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934171AbdDEVYM (ORCPT ); Wed, 5 Apr 2017 17:24:12 -0400 Received: from mx1.redhat.com ([209.132.183.28]:34344 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933926AbdDEVYC (ORCPT ); Wed, 5 Apr 2017 17:24:02 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 78A698046D Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=dledford@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 78A698046D Subject: Re: [PATCH] IB/hns: include linux/of.h to fix build failure To: Tobias Regnery , oulijun@huawei.com, xavier.huwei@huawei.com, linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org References: <20170404133637.18643-1-tobias.regnery@gmail.com> From: Doug Ledford Message-ID: <07983650-b4b9-eb61-1111-e14f88ea4452@redhat.com> Date: Wed, 5 Apr 2017 17:23:28 -0400 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170404133637.18643-1-tobias.regnery@gmail.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="5baKP7QQckOi2fArUdDsnTXPnOE2i4vgd" X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Wed, 05 Apr 2017 21:24:02 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3262 Lines: 87 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --5baKP7QQckOi2fArUdDsnTXPnOE2i4vgd Content-Type: multipart/mixed; boundary="o4Q4GrK0aufrcHshIVCk8imDlCU5IJqN5"; protected-headers="v1" From: Doug Ledford To: Tobias Regnery , oulijun@huawei.com, xavier.huwei@huawei.com, linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org Message-ID: <07983650-b4b9-eb61-1111-e14f88ea4452@redhat.com> Subject: Re: [PATCH] IB/hns: include linux/of.h to fix build failure References: <20170404133637.18643-1-tobias.regnery@gmail.com> In-Reply-To: <20170404133637.18643-1-tobias.regnery@gmail.com> --o4Q4GrK0aufrcHshIVCk8imDlCU5IJqN5 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 4/4/2017 9:36 AM, Tobias Regnery wrote: > I see the following build error in an arm64 randconfig build: >=20 > drivers/infiniband/hw/hns/hns_roce_hw_v1.c: In function 'hns_roce_v1_re= set': > drivers/infiniband/hw/hns/hns_roce_hw_v1.c:1384:15: error: implicit dec= laration of function 'of_parse_phandle' [-Werror=3Dimplicit-function-decl= aration] >=20 > Fix this by including linux/of.h directly. >=20 > Signed-off-by: Tobias Regnery > --- > This is against next-20170404 >=20 > drivers/infiniband/hw/hns/hns_roce_hw_v1.c | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git a/drivers/infiniband/hw/hns/hns_roce_hw_v1.c b/drivers/infin= iband/hw/hns/hns_roce_hw_v1.c > index ec68f56e8ee5..0f7e85c7b70b 100644 > --- a/drivers/infiniband/hw/hns/hns_roce_hw_v1.c > +++ b/drivers/infiniband/hw/hns/hns_roce_hw_v1.c > @@ -33,6 +33,7 @@ > #include > #include > #include > +#include > #include > #include "hns_roce_common.h" > #include "hns_roce_device.h" >=20 Hi Tobias, I already picked up this same change from another person. Thanks. --=20 Doug Ledford GPG Key ID: B826A3330E572FDD Key fingerprint =3D AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FD= D --o4Q4GrK0aufrcHshIVCk8imDlCU5IJqN5-- --5baKP7QQckOi2fArUdDsnTXPnOE2i4vgd Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBCAAGBQJY5WBQAAoJELgmozMOVy/dR8EP/RqWKkd3UZ7helBXyqWR1b4j fK4NXhQRzUwm0tgEuSCQbxwkowL2XMxX0sqARyuWYKeL0mxy2ga/C1KWxbvVeYBE 0OOKhMwZfgW4Pa9sU7otDeQK0eK2FNxWgt8x6j6qY3U02rvo9nL38DB2rQeRrfRs T5GslaOztgrL0PVLbXhYm6sWKV9Afmww6EuDXbwh0e21oviKSe4FtOiEVJYDuSrw AUHc0BoKyOKR+kP9UwM5c2cXIaR/PVFZobwUr83doPBXsxmED274E9AwgVLjp/pM uXIfNDVZ39JBPoaDAmb3rt7ff10WL1fZ0cfI/ZtQa9aHdWWzwqj9K+Ikovau46W1 H2kEYVCyQAMISVDrEY3WSIMdfrPgHwSJbgjVdsbEE7daooxMN+PhoQzQPJzsyNoa jIM7OH9xNw9Je40IhmEWQ5Zpx0UILCLo+lJkd4hvDuLNRMUvYN1p4wOH+3jT5LYI 1kQj7CG35n17i+ZSLkjN0bfK8YZzzqe4KbRUYgzUpm6/Y0Pscwa8zGTMBWxnt5ly ttjmVnNWTxAV9MeEg3DO36fTD/SLX+RssK6WcxhL5VIs2siHRf4pox2Hc6G9D9Gt DxnFzJj9YUCd9NHB5InrT4nlZ9RwwdDH9AdDe1zcuK1VqQjExZWtSe5x6uG9gCF7 VyFUm1hq6q/qC3dmhPMY =7oKm -----END PGP SIGNATURE----- --5baKP7QQckOi2fArUdDsnTXPnOE2i4vgd--