Date: Wed, 5 Apr 2017 16:55:24 -0700
From: Calvin Owens <calvinowens@fb.com>
To: Steven Rostedt <rostedt@goodmis.org>
CC: Petr Mladek <pmladek@suse.com>,
        Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Jiri Slaby <jslaby@suse.cz>, Andrew Morton <akpm@linux-foundation.org>,
        Manuel =?utf-8?Q?Sch=C3=B6lling?= <manuel.schoelling@gmx.de>,
        Hans de Goede <hdegoede@redhat.com>,
        Paul Burton <paul.burton@imgtec.com>, <linux-kernel@vger.kernel.org>,
        <kernel-team@fb.com>
Subject: Re: [RFC][PATCH 2/2] printk: Add /sys/consoles/${con}/ and maxlevel
 attribute
Message-ID: <20170405235524.kqbfzihbyy3lwtps@Haydn>
References: <bc1fe800930be76761b2bb4e6108fe5876a005c9.1491345440.git.calvinowens@fb.com>
 <8d144e1ec0c18761c4a6e14353e49e81a81bc924.1491345440.git.calvinowens@fb.com>
 <20170404233050.3afba596@gandalf.local.home>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
In-Reply-To: <20170404233050.3afba596@gandalf.local.home>
User-Agent: NeoMutt/20170306 (1.8.0)
SpamDiagnosticOutput: 1:99
SpamDiagnosticMetadata: NSPM
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Apr 2017 23:55:29.4314 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR15MB1221
X-OriginatorOrg: fb.com
X-Proofpoint-Spam-Reason: safe
X-FB-Internal: Safe
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-04-05_17:,,
 signatures=0
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 796
Lines: 25

On Tuesday 04/04 at 23:30 -0400, Steven Rostedt wrote:
> On Tue, 4 Apr 2017 16:03:20 -0700
> Calvin Owens <calvinowens@fb.com> wrote:
> 
> > This does the simplest possible thing: add a directory at the root of
> > sysfs that allows setting the "maxlevel" parameter for each console.
> > 
> > We can let kobject destruction race with console removal: if it does,
> > maxlevel_{show,store}() will safely fail with -ENODEV. This is a little
> > weird, but avoids embedding the kobject and therefore needing to totally
> > refactor the way we handle console struct lifetime.
> 
> Can you also add a patch that allows this to be set on the kernel
> command line, when the consoles are defined.

Absolutely :)

Thanks,
Calvin

 
> -- Steve
> 
> > 
> > Signed-off-by: Calvin Owens <calvinowens@fb.com>